Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] SIG-Auth initial charter #2000

Closed
wants to merge 3 commits into from
Closed

Conversation

tallclair
Copy link
Member

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/auth Categorizes an issue or PR as relevant to SIG Auth. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 4, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: liggitt

Assign the PR to them by writing /assign @liggitt in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt
Copy link
Member

liggitt commented Apr 4, 2018

cc @kubernetes/steering-committee @kubernetes/sig-auth-proposals

@k8s-ci-robot k8s-ci-robot added the kind/design Categorizes issue or PR as related to design. label Apr 4, 2018
@@ -0,0 +1,150 @@
# SIG Auth Governance
Copy link
Member

@liggitt liggitt Apr 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this jumps into structure/governance, but doesn't actually include the charter (current original charter/goals/non-goals inlined at https://github.com/kubernetes/community/blob/master/sig-auth/README.md#goals)

do we want to move that into this document? separately, those could use some updating/clarification, but probably best to tackle that in another PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the charter / mission statement / goals are more broadly useful (and interesting). What do you think of keeping that content in the README, and instead renaming this document to "governance.md"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

- Technical Leads *MAY* select additional tech leads through a [super-majority] vote amongst tech
leads and chairs. This *SHOULD* be supported by a majority of SIG Members under
[lazy-consensus].
- Technical Leads *MUST* remain active in the role and are automatically removed from the position
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might consider rewording this to allow for a short-term planned absence (paternity/maternity leave, sabbatical, etc) with coordination to cover responsibilities. same comment for chairs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@tallclair
Copy link
Member Author

/assign @liggitt @ericchiang

@liggitt
Copy link
Member

liggitt commented May 23, 2018

LGTM
/hold
for @ericchiang and ack from @kubernetes/steering-committee

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 23, 2018
@ericchiang
Copy link
Contributor

lgtm

subproject
- *MUST* proactively maintain the subproject health and status or delegate this
responsibility. For actively developed projects, this *SHOULD* include setting milestone
priorities, tracking release bits, and ensure adequate test coverage. For maintenance mode
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/ensure/ensuring

@mikedanese
Copy link
Member

Who is responsible for semi-regular sig/auth issue triage?
Who is first point of contact to direct flaky/failing tests to subproject owners?

@tallclair
Copy link
Member Author

Other questions from OOB discussion w/ @liggitt

  • what are chair roles?
  • do chairs make technical decisions?
  • what do chairs do around release?
  • do chairs or TLs make call on what features get into milestones?
  • PRs vs spreadsheets

We need to revisit the list of responsibilities with specific examples.

@pwittrock pwittrock added the committee/steering Denotes an issue or PR intended to be handled by the steering committee. label Jun 21, 2018
# SIG Auth Governance

## Roles

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the mission / scope / subprojects?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 See the SIG charter template if you need some guidance

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to help brainstorm this with y'all.

Copy link

@michelleN michelleN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tallclair @liggitt @ericchiang !

Thanks for submitting your charter. Please add a Scope section like the one in this template: https://github.com/kubernetes/community/blob/master/committee-steering/governance/sig-charter-template.md
We'd like for SIG charters to give everyone an idea of what areas of interest your SIG covers and the part of the code base or any sub projects it is responsible for. Appreciate your time!

# SIG Auth Governance

## Roles

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 See the SIG charter template if you need some guidance

@tallclair
Copy link
Member Author

/unassign @ericchiang
/assign @mikedanese

especially over areas for which they are the owner
- *MAY* be removed if not proactively working with other Subproject Owners to fulfill
responsibilities.
- *MAY* decide to step down at any time and propose a replacement. Use [lazy-consensus] amongst
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a subproject has no effective leadership would it fall to majority of the SIG or the TLs of the SIG to solve/address this?

they have defined.

- Proposing and making decisions
- Proposals *SHOULD* be sent as [KEP] PRs and published to [kubernetes-sig-auth] as an
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to document here who needs to be set as an approver when doing a KEP. My guess is that for stuff that impacts most of the SIG it'd be a TL (with acceptance from that TL and lazy consensus around that choice). Similarly for something that is solely scoped to a subproject it'd be a subproject owner w/ lazy consensus.

@philips
Copy link
Contributor

philips commented Jul 20, 2018

Thank you for your patience as we work to your SIG charter merged.

Through the process of reviewing the first 11 charters the Steering Committee (SC) found a lot of copy/paste language caused by our poorly designed initial charter template. To fix this there is a new SIG charter template which focuses on the main things we want to see in charters: scope and responsibilities.

Please consider updating to this charter template and putting focus into the scope and responsibilities. SC members will focus more on a deep review of scope more than anything else and using this template will help with that focus.

@tallclair tallclair mentioned this pull request Jul 28, 2018
@tallclair
Copy link
Member Author

In the interest of preserving the history in this PR, I opened a new PR with the updated charter #2431

RIP #2000

@tallclair tallclair closed this Jul 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. committee/steering Denotes an issue or PR intended to be handled by the steering committee. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/design Categorizes issue or PR as related to design. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants