Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SIG Cloud Provider #2201

Merged
merged 3 commits into from
Jun 1, 2018

Conversation

andrewsykim
Copy link
Member

@andrewsykim andrewsykim commented May 30, 2018

As discussed with @kubernetes/steering-committee. Discussion here.

I will be removing wg-cloud-provider related files in a follow up PR once everything for sig-cloud-provider is solidified.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 30, 2018
@k8s-ci-robot k8s-ci-robot requested review from calebamiles and jbeda May 30, 2018 21:22
@k8s-ci-robot k8s-ci-robot added the sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. label May 30, 2018
@andrewsykim andrewsykim force-pushed the sig-cloud-provider branch from 49d993f to 8754509 Compare May 30, 2018 21:25
* Deployment tooling which has historically resided under [cluster/](https://github.com/kubernetes/kubernetes/tree/release-1.11/cluster)
* Code ownership for all cloud providers that fall under the kubernetes organization and have opted to be subprojects of SIG Cloud Provider. Following the guidelines around subprojects we anticipate providers will have full autonomy to maintain their own repositories, however, official code ownership will still belong to SIG Cloud Provider.
* [cloud-provider-azure](https://github.com/kubernetes/cloud-provider-azure)
* [cloud-provider-gcp](https://github.com/kubernetes/cloud-provider-gcp)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

* Code ownership for all cloud providers that fall under the kubernetes organization and have opted to be subprojects of SIG Cloud Provider. Following the guidelines around subprojects we anticipate providers will have full autonomy to maintain their own repositories, however, official code ownership will still belong to SIG Cloud Provider.
* [cloud-provider-azure](https://github.com/kubernetes/cloud-provider-azure)
* [cloud-provider-gcp](https://github.com/kubernetes/cloud-provider-gcp)
* [cloud-provider-openstack](https://github.com/kubernetes/cloud-provider-openstack)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me. cc @dklyle

* [cloud-provider-azure](https://github.com/kubernetes/cloud-provider-azure)
* [cloud-provider-gcp](https://github.com/kubernetes/cloud-provider-gcp)
* [cloud-provider-openstack](https://github.com/kubernetes/cloud-provider-openstack)
* [cloud-provider-vsphere](https://github.com/kubernetes/cloud-provider-vsphere)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewsykim How about cloud-provider-alicloud for now ? Should we add it here now ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewsykim , Additional comments for @aoxn , The cloud provider of Alibaba Cloud is in https://github.com/AliyunContainerService/alicloud-controller-manager and we hope it can be hosted under Kubernetes organization. Thanks

Copy link
Contributor

@xlgao-zju xlgao-zju Jun 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewsykim I am also looking forward to getting the cloud-provider-alicloud into kubernetes community too. It will be much easier for users to setup and manage kubernetes on alicloud.

cc @aoxn @denverdino

Copy link
Member Author

@andrewsykim andrewsykim Jun 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list of repos in the charter is the existing repos (belonging to existing SIGs) that would immediately fall under sig-cloud-provider ownership. Once the SIG is formed we will have a formal process in place for new providers :).

* [cloud-controller-manager](https://github.com/kubernetes/kubernetes/tree/master/cmd/cloud-controller-manager)
* Deployment tooling which has historically resided under [cluster/](https://github.com/kubernetes/kubernetes/tree/release-1.11/cluster)
* Code ownership for all cloud providers that fall under the kubernetes organization and have opted to be subprojects of SIG Cloud Provider. Following the guidelines around subprojects we anticipate providers will have full autonomy to maintain their own repositories, however, official code ownership will still belong to SIG Cloud Provider.
* [cloud-provider-azure](https://github.com/kubernetes/cloud-provider-azure)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OWNERS_ALIASES Outdated
@@ -32,6 +32,10 @@ aliases:
- soltysh
- pwittrock
- AdoHe
sig-cloud-provider-leads:
- andrewsykim
- jagosan
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the author of the original charter, someone who's worked closely with the sig-docs and sig-testing teams, and has been an active participant in the group that has openly advocated to the benefit of all cloud providers, I would also like to be named as a co-lead in this sig.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any concerns with deadlocks if the number of leads is even? How are decisions arbitrated?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spoke with Jago and Sid, Sid (wlan0) plans to step down as chair (due to other obligations) so we should be good to have Chris onboard while also addressing @jdumars concerns around deadlocks.

Copy link

@hogepodge hogepodge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some additional comments about scope and leadership.

OWNERS_ALIASES Outdated
@@ -32,6 +32,10 @@ aliases:
- soltysh
- pwittrock
- AdoHe
sig-cloud-provider-leads:
- andrewsykim
- jagosan

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the author of the original charter, someone who's worked closely with the sig-docs and sig-testing teams, and has been an active participant in the group that has openly advocated to the benefit of all cloud providers, I would also like to be named as a co-lead in this sig.

The long term goal of SIG Cloud Provider is to promote a vendor neutral ecosystem for our community. Vendors wanting to support Kubernetes should feel equally empowered to do so
as any of today’s existing cloud providers; but more importantly ensuring a high quality user experience across providers. The SIG will act as a central group for developing
the Kubernetes project in a way that ensures all providers share common privileges and responsibilities. Below are some concrete goals on how SIG Cloud Provider plans to accomplish this.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like us to add a section about advocacy that includes supporting provider working group meetings at events and other use of community resources. One of the large impacts this will have on the community is the potential loss of collaboration and meeting space at events.

SIG-OpenStack, for example, regularly has between 40-60 attendees at it's SIG meetings at KubeCon, and the loss of access to these resources will be one of the largest impacts our community will feel.

Copy link
Member Author

@andrewsykim andrewsykim Jun 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We spoke about this on slack, we'll be addressing this during the transitional period and add more details in the charter (or in a KEP) in the near future.

@andrewsykim andrewsykim force-pushed the sig-cloud-provider branch from 8754509 to 409bd64 Compare May 31, 2018 18:27
@andrewsykim andrewsykim force-pushed the sig-cloud-provider branch from 409bd64 to e058f15 Compare May 31, 2018 18:31
@calebamiles
Copy link
Contributor

/assign

@calebamiles
Copy link
Contributor

/approve

@calebamiles
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: calebamiles

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 1, 2018
@k8s-ci-robot k8s-ci-robot merged commit d4bd6d7 into kubernetes:master Jun 1, 2018
calebamiles pushed a commit to calebamiles/community that referenced this pull request Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants