Add sig-ibmcloud Charter #2555

spzala · 2018-08-18T02:50:22Z

Add charter for IBMCloud SIG. This PR is reviewed and discussed in the SIG meeting.

spzala · 2018-08-18T02:52:14Z

/hold
Need to hold because specific reviewers are not assigned for the SIG yet.
/cc @spiffxp @duglin @bradtopol

duglin · 2018-08-18T12:11:08Z

sig-ibmcloud/charter.md

+
+This SIG adheres to the Roles and Organization Management outlined in [sig-governance]
+and opts-in to updates and modifications to [sig-governance], with exception that the SIG only
+have Chair role at present.


s/have/has the /

idvoretskyi

/lgtm

Add charter for IBMCloud SIG.

duglin · 2018-08-20T13:52:05Z

/approve

duglin · 2018-08-20T13:52:44Z

/assign @idvoretskyi

idvoretskyi

/approve

spiffxp · 2018-08-20T15:46:35Z

/committee steering

spiffxp

This needs to be fleshed out more. We don't yet have an individual cloud provider sig charter merged, but SIG VMWare's PR is quite close. I would also want to see specifically how you compare and contrast with SIG Cloud Provider

spiffxp · 2018-08-31T22:10:30Z

sig-ibmcloud/charter.md

+The IBMCloud SIG enables activities and discussion around building, deploying, maintaining, supporting,
+and using Kubernetes, and related CNCF projects, on IBM Public and Private Clouds.
+
+The authoritative source for SIG information is the [SIG README] file.


Nope, please list it here. Your README is barren as far as scope. Specifically, please list:

Code, Binaries, Services

Cross-cutting and Externally Facing Processes

We don't have code repos etc yet as I mentioned in another comment as well, but creating provider repo is a work in progress right now and we will be updating charter once it happens. I think we can safely remove the line mentioning README, and will do it. Thanks!

I would look to SIG VMWare's in-flight charter for some prior art here, with the caveat that I currently have some unaddressed nits there. I think they do a good job of taking ownership of community management and best practices in a way that articulates some artifacts and processes.

Yup, agree that it's nicely written. I will try elaborate on scope. Thanks!!

spiffxp · 2018-08-31T22:11:31Z

sig-ibmcloud/charter.md

+and opts-in to updates and modifications to [sig-governance], with exception that the SIG only
+has the Chair role at present.
+
+- SIG meets every other week on Zoom at 2 PM ET on Wednesday.


Out of scope for the charter doc

I am fine removing it but I used some of the already merged charter as reference and charters like sig-azure, cloud-provider, service-catalog (https://github.com/kubernetes/community/blob/master/sig-service-catalog/charter.md) have a similar addition. Also, as most SIGs charter (and charter template) has reference to the sig-governance (https://github.com/kubernetes/community/blob/master/committee-steering/governance/sig-governance.md) where it has a similar mention on meeting schedule, so my understanding was in the charter we provide a concise meeting detail etc. Again, I am fine to remove it if we decide so. Thanks!

You managed to pick as prior art three charters that merged either without much SC review, or before we got stricter about sticking to a common template. We plan on ensuring those change to match the template.

You can check kubernetes/steering#31 to see more info

That you meet regularly is an expectation that doesn't need to be spelled out here. When and how should be spelled out in sigs.yaml

Ah, LOL, OK sounds good to me 👍

spiffxp · 2018-08-31T22:12:15Z

sig-ibmcloud/charter.md

+
+This SIG adheres to the Roles and Organization Management outlined in [sig-governance]
+and opts-in to updates and modifications to [sig-governance], with exception that the SIG only
+has the Chair role at present.


Does this mean there are no duties for a Tech Lead to perform? Or that the Chair satisfies the duties of Tech Lead?

Yes, the chair role satisfies the duties as of today. We don't have code repo etc yet but once we have we will rethink on adding Tech lead role. Hope makes sense.

Can add a sentence stating this explicitly? eg: "Chairs must also fulfill all of the responsibilities of the Tech Lead role as outlined in [sig-governance]" (with a link)

Yup, absolutely, will do!

spiffxp · 2018-08-31T22:16:36Z

sig-ibmcloud/charter.md

+      [here](https://goo.gl/PSkwBj).
+    - SIG mailing list link
+      [here](https://goo.gl/hUF9eF).
+


You're missing the section on Subproject Creation.

We don't have any subproject yet so it's not mentioned. I am fine if it's good to add a section with none for now? Thanks!

This is about documenting the process you will follow when you make a subproject. You need to choose an option from the template:

Option 1: by SIG Technical Leads

Option 2: by Federation of Subprojects

Also, I'm not entirely sure how on board I am with the notion of a SIG that owns no artifacts within this project. I guess I can find no prior art for this expectation other than "areas the SIG is responsible for directing and maintaining"

Is there code you own? Are there docs?

I see, I thought it's something related to existing sub projects. We don't have one yet but we have discussed this in SIG. We have provider code but not yet public and it's WIP to have a pubic repo. Thanks!

spzala

@spiffxp Aaron, hi, thanks so much for the review and comments. I have answered your comments inline.

spiffxp · 2018-09-11T22:57:29Z

Ping, any updates on this?

spzala · 2018-09-12T14:33:43Z

@spiffxp hello, sorry I was OOO, just created second commit. Thanks!

Add charter for IBMCloud SIG.

spiffxp · 2018-09-17T22:20:50Z

sig-ibmcloud/charter.md

+
+The work to have a cloud provider specific public code repository is in progress. This section will be updated once the work is complete. Kubernetes upstream code that
+is directly related to IKS or ICP issues or features can be discussed.
+


You're missing the "Cross-cutting and Externally Facing Processes" section. I assume this means you have none.

Yes, you got it right :) Thanks!

spiffxp · 2018-09-17T22:40:44Z

/lgtm
That said, this looks really light. There are currently 5 other SIGs that have no subprojects listed, so you're not alone on this, but I anticipate we'll want to resolve this down the line.

/assign @derekwaynecarr
you're the other steering committee member for this

spzala · 2018-09-17T23:12:39Z

@spiffxp, thanks Aaron!! Yes, agree, we should have one or more in future as we work on open sourcing the provider code.

derekwaynecarr · 2018-09-21T14:50:48Z

sig-ibmcloud/charter.md

+has the Chair role at present. Chairs must also fulfill all of the responsibilities of the Tech Lead role as outlined in [sig-governance].
+
+### Subproject Creation
+Associated subprojects are created following the `by SIG Technical Leads` option procedure described in [sig-governance].


nit: you can just say "SIG Technical Leads" in this section.

as an example: https://github.com/kubernetes/community/pull/2462/files#diff-ddf39acdb13e6743dcb3d690a0a68f96R60

i assume creation of subprojects will also be impacted by changes in "code, binaries, services" discussion.

derekwaynecarr · 2018-09-21T14:57:25Z

I do not have a great sense on the scope of subprojects that could potentially be sponsored by this sig since there really are none yet. i would like to revisit this in the future once the code, binaries, and services section is better fleshed out. i agree w/ aaron that we can resolve this down the line.

/hold cancel
/lgtm
/approve

k8s-ci-robot · 2018-09-21T14:57:33Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, duglin, idvoretskyi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~sig-ibmcloud/OWNERS~~ [derekwaynecarr,idvoretskyi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 18, 2018

k8s-ci-robot requested review from castrojo and jdumars August 18, 2018 02:50

k8s-ci-robot added the area/provider/ibmcloud Issues or PRs related to ibmcloud provider label Aug 18, 2018

k8s-ci-robot requested review from bradtopol, duglin and spiffxp August 18, 2018 02:52

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 18, 2018

duglin reviewed Aug 18, 2018

View reviewed changes

k8s-ci-robot assigned idvoretskyi Aug 18, 2018

idvoretskyi approved these changes Aug 18, 2018

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2018

Add sig-ibmcloud Charter

e38904b

Add charter for IBMCloud SIG.

spzala force-pushed the sigibmcloudcharter branch from 4eca286 to e38904b Compare August 19, 2018 21:14

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2018

idvoretskyi approved these changes Aug 20, 2018

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2018

k8s-ci-robot added the committee/steering Denotes an issue or PR intended to be handled by the steering committee. label Aug 20, 2018

rtheis approved these changes Aug 22, 2018

View reviewed changes

jdumars mentioned this pull request Aug 29, 2018

Charters Meta-issue kubernetes/steering#31

Closed

spiffxp suggested changes Aug 31, 2018

View reviewed changes

spzala commented Sep 4, 2018

View reviewed changes

spzala force-pushed the sigibmcloudcharter branch from 0003a69 to 575f47c Compare September 12, 2018 14:31

Add sig-ibmcloud Charter

4037c92

Add charter for IBMCloud SIG.

spzala force-pushed the sigibmcloudcharter branch from 575f47c to 4037c92 Compare September 12, 2018 19:05

spiffxp reviewed Sep 17, 2018

View reviewed changes

k8s-ci-robot assigned spiffxp and derekwaynecarr Sep 17, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2018

derekwaynecarr reviewed Sep 21, 2018

View reviewed changes

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2018

k8s-ci-robot merged commit 9b9420e into kubernetes:master Sep 21, 2018


		The work to have a cloud provider specific public code repository is in progress. This section will be updated once the work is complete. Kubernetes upstream code that
		is directly related to IKS or ICP issues or features can be discussed.

Add sig-ibmcloud Charter #2555

Add sig-ibmcloud Charter #2555

Conversation

spzala commented Aug 18, 2018

spzala commented Aug 18, 2018

duglin Aug 18, 2018 • edited Loading

Choose a reason for hiding this comment

idvoretskyi left a comment

Choose a reason for hiding this comment

duglin commented Aug 20, 2018

duglin commented Aug 20, 2018

idvoretskyi left a comment

Choose a reason for hiding this comment

spiffxp commented Aug 20, 2018

spiffxp left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

spiffxp Sep 4, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

spzala left a comment

Choose a reason for hiding this comment

spiffxp commented Sep 11, 2018

spzala commented Sep 12, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

spiffxp commented Sep 17, 2018

spzala commented Sep 17, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

derekwaynecarr commented Sep 21, 2018

k8s-ci-robot commented Sep 21, 2018

duglin Aug 18, 2018 •

edited

Loading

spiffxp Sep 4, 2018 •

edited

Loading