Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIG Multicluster charter #2561

Merged
merged 1 commit into from
Oct 22, 2018
Merged

SIG Multicluster charter #2561

merged 1 commit into from
Oct 22, 2018

Conversation

pmorie
Copy link
Member

@pmorie pmorie commented Aug 20, 2018

Replaces #1989 as a WIP for SIG multicluster charter.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 20, 2018
@csbell
Copy link
Contributor

csbell commented Aug 20, 2018

/approve

@marun
Copy link
Contributor

marun commented Aug 20, 2018

lgtm

@k8s-ci-robot k8s-ci-robot assigned ghost Aug 20, 2018
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmorie - Thanks for updating!

Would it be possible to try and add more specifics? We're trying hard to make certain we're explicit and well scoped in the charters, because otherwise responsibilities get all muddled.

/assign @quinton-hoole


The scope of SIG Multicluster includes:

- Solving common challenges related to management of multiple Kubernetes clusters and the applications that exist therein
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really broad, could you scope it down?

e.g. - what aspects?

  • Networking, application mgmt, disaster recovery, etc.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the most sensible thing to say here is probably to be really specific about the scopes of the existing projects, which are:

  • cluster-registry
  • federation-v2
  • kubemci

I don't think it's especially useful to have a vague prose description of the scope - since this SIG is essentially focused entirely around these projects at this point.

Copy link
Member

@timothysc timothysc Aug 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the most sensible thing to say here is probably to be really specific about the scopes of the existing projects

Agreed, we want to make certain the areas of responsibility translate to specific areas of ownership so we can start to rationalize the SIGs across the project.

@philips
Copy link
Contributor

philips commented Aug 20, 2018

/cc @spiffxp

@spiffxp
Copy link
Member

spiffxp commented Aug 31, 2018

/unassign @quinton-hoole
/assign

@k8s-ci-robot k8s-ci-robot assigned spiffxp and unassigned ghost Aug 31, 2018
@spiffxp
Copy link
Member

spiffxp commented Aug 31, 2018

/committee steering

@k8s-ci-robot k8s-ci-robot added the committee/steering Denotes an issue or PR intended to be handled by the steering committee. label Aug 31, 2018
@spiffxp
Copy link
Member

spiffxp commented Aug 31, 2018

/assign @timothysc

Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to more specifics


#### Code, Binaries and Services

- Mechanisms in Kubernetes that track information about multiple clusters
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be less vague. spartakus tracks information about multiple clusters, in the sense that they all ping it... but I doubt that's under your purview


### Out of scope

- Software that creates or manages the lifecycle of Kubernetes clusters
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which SIG (if any) would own reconciliation between cluster-api and cluster-registry?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had hoped to address that by narrowly defining the scope of the SIG. I will add a note that specifically addresses the situation where another part of the community plans an integration between another piece of software and one that is in scope for the SIG.

@spiffxp
Copy link
Member

spiffxp commented Sep 11, 2018

Ping, any updates on this?

@pmorie
Copy link
Member Author

pmorie commented Oct 1, 2018

@spiffxp @timothysc changes pushed, tried to be very specific.

@timothysc
Copy link
Member

@pmorie am I missing something, I don't see an updated PR?

@pmorie
Copy link
Member Author

pmorie commented Oct 9, 2018

@timothysc it sure helps if you push to the right branch; apologies!

@timothysc
Copy link
Member

/hold

Pending @spiffxp feedback.

I don't really have issues with the current form, but it may be a bit limiting. I'd leave that to the chairs to decide.

/approve

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csbell, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2018
@spiffxp
Copy link
Member

spiffxp commented Oct 18, 2018

This looks like over-specification to me, especially compared to the description in sigs.yaml. Things mentioned there I don't see here:

  • tools related to multi-cluster administration and application management
  • batch-workflow continuous deployment systems like Spinnaker and others
  • changes to kubernetes core where appropriate
  • anything around common practices or approaches to the use of multiple clusters

/lgtm
I'll LGTM this as is, but I would anticipate some iteration will need to happen here

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 18, 2018
@spiffxp
Copy link
Member

spiffxp commented Oct 18, 2018

Please /hold cancel if you're happy with this in its current form @pmorie

@pmorie
Copy link
Member Author

pmorie commented Oct 22, 2018

@spiffxp @timothysc I agree that it is very specific at this point, I found it hard to determine exactly what the right level of detail was and decided to err on being overly specific rather than overly broad.

I'm fine iterating on this in follow-ups, canceling hold.

Thanks for the reviews!

/hold cancel

@spiffxp
Copy link
Member

spiffxp commented Oct 22, 2018

The /hold command wasn't picked up due to an ongoing github incident. Linking to see if this gets picked back up when github recovers

kubernetes/test-infra#9881

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 22, 2018
@k8s-ci-robot k8s-ci-robot merged commit 3005cd4 into kubernetes:master Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. committee/steering Denotes an issue or PR intended to be handled by the steering committee. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants