Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically update OWNERS_ALIASES for UGs #3359

Merged
merged 1 commit into from
Mar 14, 2019
Merged

Automatically update OWNERS_ALIASES for UGs #3359

merged 1 commit into from
Mar 14, 2019

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented Mar 5, 2019

Got missed in #3298 :(

/cc @spiffxp @idealhack @erikerlandson

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. labels Mar 5, 2019
@nikhita
Copy link
Member Author

nikhita commented Mar 5, 2019

I checked #3304 out locally and can confirm this works now fwiw.

@nikhita nikhita mentioned this pull request Mar 5, 2019
Merged
@erikerlandson
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2019
@nikhita
Copy link
Member Author

nikhita commented Mar 5, 2019

/assign @spiffxp
for approval

@erikerlandson
Copy link
Contributor

bump

@nikhita
Copy link
Member Author

nikhita commented Mar 12, 2019

/assign @grodrigues3
can you approve?

@dims
Copy link
Member

dims commented Mar 14, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2019
@dims
Copy link
Member

dims commented Mar 14, 2019

/assign @spiffxp

@k8s-ci-robot k8s-ci-robot merged commit c2f4d5b into kubernetes:master Mar 14, 2019
@nikhita nikhita deleted the ug-owners-aliases branch March 15, 2019 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikerlandson erikerlandson Awaiting requested review from erikerlandson

@idealhack idealhack Awaiting requested review from idealhack

@spiffxp spiffxp Awaiting requested review from spiffxp

Assignees

@spiffxp spiffxp

@erikerlandson erikerlandson

@grodrigues3 grodrigues3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nikhita @erikerlandson @dims @k8s-ci-robot @spiffxp @grodrigues3