Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for User Groups in sigs.yaml #3298

Merged
merged 1 commit into from
Mar 4, 2019
Merged

Add support for User Groups in sigs.yaml #3298

merged 1 commit into from
Mar 4, 2019

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented Feb 24, 2019

Fixes #3297

User Groups were added in #3174. This PR adds support for documenting them in sigs.yaml. Ref: #2988 (comment).

/cc @cblecker @parispittman
/sig contributor-experience

/cc @spiffxp
/committee steering

@k8s-ci-robot k8s-ci-robot added sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. committee/steering Denotes an issue or PR intended to be handled by the steering committee. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 24, 2019
@nikhita nikhita mentioned this pull request Feb 24, 2019
Closed
@nikhita nikhita force-pushed the user-groups-sigs-yaml branch from 3f4f6e3 to 1446d1b Compare February 25, 2019 10:43
@spiffxp
Copy link
Member

spiffxp commented Feb 25, 2019

/approve
I'd like another pair of eyes for the /lgtm

As a side note, we now have N=3 of these sets of groups, I think the next step would be to refactor away some of the copy-pasta we have going on.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2019
@cblecker
Copy link
Member

we now have N=3 of these sets of groups

What about committees?

@cblecker
Copy link
Member

/hack/verify-generated-docs.sh needs to be updated too

@erikerlandson erikerlandson mentioned this pull request Feb 25, 2019
Merged
@nikhita nikhita force-pushed the user-groups-sigs-yaml branch from 1446d1b to 1816b3e Compare February 25, 2019 22:39
@nikhita
Copy link
Member Author

nikhita commented Feb 25, 2019

@cblecker Updated. PTAL.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhita, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nikhita
Copy link
Member Author

nikhita commented Feb 25, 2019

What about committees?

I also thought of adding this in sigs.yaml for completeness, but wanted to punt it to another issue/PR.

@cblecker
Copy link
Member

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Feb 26, 2019
@dims
Copy link
Member

dims commented Feb 26, 2019

/lgtm

@jbeda
Copy link
Contributor

jbeda commented Feb 26, 2019

/lgtm

@nikhita
Copy link
Member Author

nikhita commented Feb 27, 2019

@spiffxp ok to cancel the hold here?

@nikhita nikhita mentioned this pull request Feb 27, 2019
Closed
@spiffxp
Copy link
Member

spiffxp commented Mar 4, 2019

/hold cancel
I've heard no objections from steering, let's move forward

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2019
@k8s-ci-robot k8s-ci-robot merged commit 831197a into kubernetes:master Mar 4, 2019
@nikhita nikhita mentioned this pull request Mar 5, 2019
Merged
@nikhita nikhita deleted the user-groups-sigs-yaml branch March 15, 2019 09:48
@nikhita nikhita mentioned this pull request Mar 15, 2019
Merged
@nikhita
Copy link
Member Author

nikhita commented Mar 15, 2019

I also thought of adding this in sigs.yaml for completeness, but wanted to punt it to another issue/PR.

Created #3437

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cblecker cblecker Awaiting requested review from cblecker

@parispittman parispittman Awaiting requested review from parispittman

@spiffxp spiffxp Awaiting requested review from spiffxp

Assignees

@dims dims

@jbeda jbeda

@cblecker cblecker

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. committee/steering Denotes an issue or PR intended to be handled by the steering committee. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nikhita @spiffxp @cblecker @k8s-ci-robot @dims @jbeda