-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generator: add support for committees #3437
Conversation
Since committees can have private mailing lists, this commit also adds a new field for specifying private mailing lists in the "Contacts" section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a couple of questions.
/hold |
Sent an email to steering ML: https://groups.google.com/a/kubernetes.io/d/topic/steering/iDkt83VedfQ/discussion |
Cool! Good idea. Thanks a lot. Probably should be called subgroups.yaml at this point, but I think changing the name would be disruptive. /approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
^ in case anyone else had comments, otherwise cancel the hold after some timeout.
cc @kubernetes/steering-committee @kubernetes/code-of-conduct-committee @kubernetes/product-security-committee I'll take #3437 (review) as lgtm from steering but will hold for comments. CoCC and PSC - can you PTAL at the changes and add lgtm if you are ok with it? Thanks! :) |
/lgtm |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bgrant0607, carolynvs, nikhita, timothysc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I'll treat @philips's lgtm as approval from PSC (and steering) and @carolynvs's lgtm as approval from CoCC. Will leave this open until Wednesday and then remove the hold. |
/lgtm |
/lgtm |
/hold cancel |
@nikhita, Do we need to go update https://github.com/kubernetes/sig-release/blob/master/security-release-process-documentation/OWNERS I'm happy to make PRs to update those 3 repos with the new name if that's the right thing to do. |
TLDR: No, that's not needed. :) I updated the alias name here because the current format works well with the go template in the generator (which generates the |
Ref: #3298 (comment)
sigs.yaml
includes all our community groups except committees. This PR adds support for committees in the generator.Note: since committees can have private mailing lists, I have added a new field
private_mailing_list
in the Contacts section. PTAL.This PR also adds the Steering Committee, the Code of Conduct Committee and the Product Security Committee in
sigs.yaml
. I'll cc them on the PR for approval for their respective sections once the generator changes get lgtm (but will send an email to the steering ML now to get a general ok for the change)./assign @spiffxp
generator owner
/sig contributor-experience
/committee steering
/committee conduct
/committee product-security