Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generator: add support for committees #3437

Merged
merged 4 commits into from
Mar 18, 2019

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented Mar 15, 2019

Ref: #3298 (comment)

sigs.yaml includes all our community groups except committees. This PR adds support for committees in the generator.

Note: since committees can have private mailing lists, I have added a new field private_mailing_list in the Contacts section. PTAL.

This PR also adds the Steering Committee, the Code of Conduct Committee and the Product Security Committee in sigs.yaml. I'll cc them on the PR for approval for their respective sections once the generator changes get lgtm (but will send an email to the steering ML now to get a general ok for the change).

/assign @spiffxp
generator owner

/sig contributor-experience
/committee steering
/committee conduct
/committee product-security

nikhita added 4 commits March 15, 2019 18:13
Since committees can have private mailing lists, this commit
also adds a new field for specifying private mailing lists
in the "Contacts" section.
@k8s-ci-robot k8s-ci-robot added sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. committee/steering Denotes an issue or PR intended to be handled by the steering committee. committee/code-of-conduct Denotes an issue or PR intended to be handled by the code of conduct committee. committee/security-response Denotes an issue or PR intended to be handled by the product security committee. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 15, 2019
Copy link
Member Author

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a couple of questions.

committee-code-of-conduct/README.md Show resolved Hide resolved
committee-steering/README.md Show resolved Hide resolved
@nikhita
Copy link
Member Author

nikhita commented Mar 15, 2019

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 15, 2019
@nikhita
Copy link
Member Author

nikhita commented Mar 15, 2019

@bgrant0607
Copy link
Member

Cool! Good idea. Thanks a lot. Probably should be called subgroups.yaml at this point, but I think changing the name would be disruptive.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2019
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

^ in case anyone else had comments, otherwise cancel the hold after some timeout.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2019
@nikhita
Copy link
Member Author

nikhita commented Mar 15, 2019

cc @kubernetes/steering-committee @kubernetes/code-of-conduct-committee @kubernetes/product-security-committee

I'll take #3437 (review) as lgtm from steering but will hold for comments.

CoCC and PSC - can you PTAL at the changes and add lgtm if you are ok with it? Thanks! :)

@philips
Copy link
Contributor

philips commented Mar 15, 2019

/lgtm

@michelleN
Copy link

/lgtm

Copy link
Contributor

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bgrant0607, carolynvs, nikhita, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [bgrant0607,timothysc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nikhita
Copy link
Member Author

nikhita commented Mar 18, 2019

I'll treat @philips's lgtm as approval from PSC (and steering) and @carolynvs's lgtm as approval from CoCC.

Will leave this open until Wednesday and then remove the hold.

@dims
Copy link
Member

dims commented Mar 18, 2019

/lgtm

@spiffxp
Copy link
Member

spiffxp commented Mar 18, 2019

/lgtm

@philips
Copy link
Contributor

philips commented Mar 18, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2019
@k8s-ci-robot k8s-ci-robot merged commit 45fd380 into kubernetes:master Mar 18, 2019
@nikhita nikhita deleted the committee-sigs-yaml branch March 19, 2019 03:43
@joelsmith
Copy link
Contributor

@nikhita
Copy link
Member Author

nikhita commented Mar 23, 2019

Do we need to go update OWNERS and OWNERS_ALIASES files that reference product-security-committee across all the repos?

TLDR: No, that's not needed. :)

I updated the alias name here because the current format works well with the go template in the generator (which generates the OWNER_ALIASES file from sigs.yaml) i.e. the only way to get the complete committee's name using the fields in sigs.yaml is to use {{.Dir}} and that uses the word committee as a prefix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. committee/code-of-conduct Denotes an issue or PR intended to be handled by the code of conduct committee. committee/security-response Denotes an issue or PR intended to be handled by the product security committee. committee/steering Denotes an issue or PR intended to be handled by the steering committee. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants