-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add subprojects for committees #3466
Conversation
- **spartakus** | ||
- Description: Collection of usage information about Kubernetes clusters. | ||
- Owners: | ||
- https://raw.githubusercontent.com/kubernetes-incubator/spartakus/master/OWNERS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this originally classified under steering? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no idea, I feel like it should be punted, but that can be a decision in a separate PR (and I would look to @thockin to make it)
it looks like the steering language in arch subproject was placeholder text for when sigs.yaml held committees. i dont think they had intention for committees to have subprojects. |
Yeah, subprojects looks weird...I can do something like this, but not sure if that adds additional complications and confusion. 🤔 type Committee struct {
Group
Repos []string
} |
/approve /hold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nikhita, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://groups.google.com/a/kubernetes.io/d/msg/steering/MGK0bDGwZNk/v5BGx750CwAJ - lazy consensus, will remove the /hold if no objections by Friday am PT |
/lgtm at some point security needs to own this for example https://github.com/philips/oncall-issue-filer |
/hold cancel The main nit is that we want to be clear these subprojects should pertain to the committees' business, rather than the kubernetes project itself. Let's address in governance docs |
Not sure if we officially say that committees can have subprojects, but I noticed steering as a subproject for sig-arch after creating #3437: https://github.com/kubernetes/community/tree/master/sig-architecture#subprojects.
Technically, committees also own repos (and thus "code") so I guess it makes sense to list these as subprojects?
/hold
/committee steering
/committee product-security
/cc @kubernetes/steering-committee @kubernetes/product-security-committee @mattfarina @jdumars
/sig contributor-experience
/assign @spiffxp
(generator owner)