Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subprojects for committees #3466

Merged
merged 3 commits into from
Mar 20, 2019

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented Mar 19, 2019

Not sure if we officially say that committees can have subprojects, but I noticed steering as a subproject for sig-arch after creating #3437: https://github.com/kubernetes/community/tree/master/sig-architecture#subprojects.

Technically, committees also own repos (and thus "code") so I guess it makes sense to list these as subprojects?

/hold
/committee steering
/committee product-security
/cc @kubernetes/steering-committee @kubernetes/product-security-committee @mattfarina @jdumars

/sig contributor-experience
/assign @spiffxp
(generator owner)

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. committee/steering Denotes an issue or PR intended to be handled by the steering committee. committee/security-response Denotes an issue or PR intended to be handled by the product security committee. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. labels Mar 19, 2019
@k8s-ci-robot k8s-ci-robot requested review from jdumars, mattfarina and a team March 19, 2019 12:43
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. labels Mar 19, 2019
- **spartakus**
- Description: Collection of usage information about Kubernetes clusters.
- Owners:
- https://raw.githubusercontent.com/kubernetes-incubator/spartakus/master/OWNERS
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this originally classified under steering? 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea, I feel like it should be punted, but that can be a decision in a separate PR (and I would look to @thockin to make it)

@parispittman
Copy link
Contributor

parispittman commented Mar 19, 2019

it looks like the steering language in arch subproject was placeholder text for when sigs.yaml held committees. i dont think they had intention for committees to have subprojects.

@nikhita
Copy link
Member Author

nikhita commented Mar 19, 2019

Yeah, subprojects looks weird...I can do something like this, but not sure if that adds additional complications and confusion. 🤔

type Committee struct {
	Group
	Repos []string
}

@spiffxp
Copy link
Member

spiffxp commented Mar 19, 2019

/approve
/lgtm
Personally for the moment I'd rather keep the structs as they are (keep the concept of subprojects around) and not over-specialize. I don't see the value in the added complexity.

/hold
I'll ask steering if they care

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhita, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2019
@spiffxp
Copy link
Member

spiffxp commented Mar 19, 2019

https://groups.google.com/a/kubernetes.io/d/msg/steering/MGK0bDGwZNk/v5BGx750CwAJ - lazy consensus, will remove the /hold if no objections by Friday am PT

@philips
Copy link
Contributor

philips commented Mar 19, 2019

/lgtm

at some point security needs to own this for example https://github.com/philips/oncall-issue-filer

@spiffxp
Copy link
Member

spiffxp commented Mar 20, 2019

/hold cancel
based on the positive responses on https://groups.google.com/a/kubernetes.io/d/msg/steering/MGK0bDGwZNk/v5BGx750CwAJ I'm moving ahead of lazy consensus

The main nit is that we want to be clear these subprojects should pertain to the committees' business, rather than the kubernetes project itself. Let's address in governance docs

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2019
@k8s-ci-robot k8s-ci-robot merged commit 5b01aef into kubernetes:master Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. committee/security-response Denotes an issue or PR intended to be handled by the product security committee. committee/steering Denotes an issue or PR intended to be handled by the steering committee. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants