Add contact (slack, mailing_list, teams) to subprojects #3483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/hold
k8s-ci-robot
added
cncf-cla: yes
spiffxp
force-pushed
the
add-subproject-contacts
branch
from
4ac3f90 to
e629b2f
Compare
|
/assign @nikhita @timothysc |
nikhita
reviewed
Mar 20, 2019
nikhita
reviewed
Mar 20, 2019
Demonstrate by adding slack channels for sig-testing subprojects that already have their own slack channels Add a GitHub team related to conformance to sig-arch's conformance definition subproject GitHub teams as implemented now are very kubernetes-org centric, I'm not trying to change that here, would suggest a followup change to allow for the use of github teams in other orgs (like kubernetes-sigs)
spiffxp
force-pushed
the
add-subproject-contacts
branch
from
9e24869 to
63dcb38
Compare
|
Lgtm. |
k8s-ci-robot
added
size/M
timothysc
approved these changes
Mar 20, 2019
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spiffxp, timothysc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
I was holding this on purpose to let another PR merge ahead of me, as I said when I dropped the /hold |
|
#3466 is mainly what I was concerned with and it doesn't appear to conflict so I won't revert |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demonstrate by adding slack channels for sig-testing subprojects
that already have their own slack channels
Add a GitHub team related to conformance to sig-arch's conformance
definition subproject
GitHub teams as implemented now are very kubernetes-org centric,
I'm not trying to change that here, would suggest a followup
change to allow for the use of github teams in other orgs
(like kubernetes-sigs)
/hold
I would rather let some other generator-related PR's get in first,
I suspect there are merge conflicts and I'd rather take the hit