Skip to content

Commit

Permalink
ingress paths are now clickable (#7487)
Browse files Browse the repository at this point in the history
* ingress paths are now clickable

remove unecessary question marks

make links safer

* adding extra question marks
  • Loading branch information
marcosdiez authored Dec 2, 2022
1 parent 8cf82d1 commit 437d055
Showing 1 changed file with 11 additions and 2 deletions.
13 changes: 11 additions & 2 deletions modules/web/src/common/components/ingressrulelist/template.html
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@
<mat-cell *matCellDef="let ingressRuleFlat">
<ng-container *ngIf="ingressRuleFlat.host">
<a href="https://{{ ingressRuleFlat.host }}"
target="_blank"> {{ ingressRuleFlat.host }} </a>
target="_blank"
rel="noopener noreferrer"> {{ ingressRuleFlat.host }} </a>
</ng-container>
<ng-container *ngIf="!ingressRuleFlat.host">-</ng-container>
</mat-cell>
Expand All @@ -46,7 +47,15 @@
<mat-header-cell *matHeaderCellDef
i18n>Path </mat-header-cell>
<mat-cell *matCellDef="let ingressRuleFlat">
{{ !!ingressRuleFlat?.path?.path ? ingressRuleFlat?.path?.path : '-' }}
<ng-container *ngIf="ingressRuleFlat?.path?.path">
<ng-container *ngIf="ingressRuleFlat.host">
<a rel="noopener noreferrer"
href="https://{{ ingressRuleFlat.host }}{{ ingressRuleFlat.path.path }}"
target="_blank">{{ ingressRuleFlat.path.path }}</a>
</ng-container>
<ng-container *ngIf="!ingressRuleFlat.host">{{ ingressRuleFlat.path.path }}</ng-container>
</ng-container>
<ng-container *ngIf="!ingressRuleFlat?.path?.path">-</ng-container>
</mat-cell>
</ng-container>
<ng-container [matColumnDef]="getIngressRulesFlatColumns()[2]">
Expand Down

0 comments on commit 437d055

Please sign in to comment.