ingress paths are now clickable

[marcosdiez]

This is a copy of #7017

---

sample YAML to test

kind: Ingress
apiVersion: networking.k8s.io/v1
metadata:
  name: kubernetes-dashboard-lb2
  namespace: kubernetes-dashboard
  annotations:
    kubernetes.io/ingress.class: nginx
    nginx.ingress.kubernetes.io/backend-protocol: HTTPS
spec:
  defaultBackend:
    service:
      name: test
      port:
        number: 80
  rules:
    - host: dashboard.mydomain.com
      http:
        paths:
          - path: /
            pathType: Prefix
            backend:
              service:
                name: kubernetes-dashboard
                port:
                  number: 443
    - host: dashboard2.mydomain.com
      http:
        paths:
          - path: /mypath
            pathType: Prefix
            backend:
              service:
                name: kubernetes-dashboard
                port:
                  number: 443
    - host: dashboard2.mydomain.com
      http:
        paths:
          - path: /mypath/morepath
            pathType: Prefix
            backend:
              service:
                name: kubernetes-dashboard
                port:
                  number: 443
    - http:
        paths:
        - path: /testpath
          pathType: Prefix
          backend:
            service:
              name: test
              port:
                number: 80
    - http:
        paths:
          - path: /icons
            pathType: ImplementationSpecific
            backend:
              resource:
                apiGroup: k8s.example.com
                kind: StorageBucket
                name: icon-assets
    - host: "foo.bar.com"
      http:
        paths:
          - pathType: Prefix
            path: "/bar"
            backend:
              service:
                name: service1
                port:
                  number: 80
    - host: "*.foo.com"
      http:
        paths:
          - pathType: Prefix
            path: "/foo"
            backend:
              service:
                name: service2
                port:
                  number: 80
    - host: foo.bar.com
      http:
        paths:
          - path: /foo
            pathType: Prefix
            backend:
              service:
                name: service1
                port:
                  number: 4200
          - path: /bar
            pathType: Prefix
            backend:
              service:
                name: service2
                port:
                  number: 8080

[maciaszczykm]

There is no need to use ?. as *ngIf above already checks that. I think it should be in the first changed line.

[floreks]

I'd actually move this logic to the typescript and use a single method to handle path.

[maciaszczykm]

Yeah, that would be the best.

[marcosdiez]

I removed the ?s.

I considered creating a typescript method (below), but I am not sure we want a method returning raw HTML.

I can change that if you guys prefer, though.

  createIngressLink(ingressRuleFlat: IngressRuleFlat): string {
    if (ingressRuleFlat.path.path) {
      if (ingressRuleFlat.host) {
        return '<a href="https://' + ingressRuleFlat.host + ingressRuleFlat.path.path + ' target="_blank">' + ingressRuleFlat.path.path + '</a>';
      } else {
        return ingressRuleFlat.path.path;
      }
    } else {
      return "-";
    }
  }

[maciaszczykm]

Use one method for URL, second for label.

[floreks]

It could also return a simple wrapper object with label and URL fields.

[codecov]

Codecov Report

Merging #7487 (cf9248d) into master (7c78264) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7487      +/-   ##
==========================================
+ Coverage   42.07%   42.09%   +0.02%     
==========================================
  Files         217      217              
  Lines       12084    12084              
  Branches      179      179              
==========================================
+ Hits         5084     5087       +3     
+ Misses       6716     6712       -4     
- Partials      284      285       +1     

[maciaszczykm]

@marcosdiez Any updates?

[marcosdiez]

@maciaszczykm ready to merge!

[maciaszczykm]

/lgtm
/approve

[maciaszczykm]

There is no need to use ?. as *ngIf above already checks that. I think it should be in the first changed line.

Actually, wait.

There should be ?. in the first *ngIf: ingressRuleFlat?.path?.path.

Same for last *ngIf you've added: !ingressRuleFlat?.path?.path.

Additionally, to simplify syntax you could use switch instead of ifs or move the code to component like @floreks suggested.

/approve cancel

[maciaszczykm]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maciaszczykm, marcosdiez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment