Limit ranges frontend #1285
Closed
Limit ranges frontend #1285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 93.85% (diff: 96.73%)@@ master #1285 diff @@
==========================================
Files 342 355 +13
Lines 3080 3171 +91
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 2888 2976 +88
- Misses 192 195 +3
Partials 0 0
|
batikanu
force-pushed
the
limitranges-frontend
branch
from
187bacd to
059b999
Compare
batikanu
force-pushed
the
limitranges-frontend
branch
4 times, most recently
from
09611ea to
6896940
Compare
|
'Limit Ranges' section is missing on admin page. Please add. |
batikanu
force-pushed
the
limitranges-frontend
branch
2 times, most recently
from
ab1f443 to
09fb8f0
Compare
|
'Limit Ranges' section is added on admin page. PTAL |
batikanu
force-pushed
the
limitranges-frontend
branch
from
09fb8f0 to
2ee815e
Compare
bryk
suggested changes
Sep 30, 2016
There was a problem hiding this comment.
Hmm... Can you show a couple of screenshots here? Should this be added to top level navigation or just as a property of a namespace?
I'm concerned about this because I think it does not make sense to look at a limit range alone. A limit range always belongs to exactly one namespace.
What do you think?
|
@bryk I think it should be like resource quotas only in namespace details. I will move limit range detail to namespace detail and post some screen shots. |
batikanu
force-pushed
the
limitranges-frontend
branch
from
2ee815e to
c8300e4
Compare
|
@batikanu Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of Limit ranges frontend.
It includes also small fixes in backend.