Resource limits frontend implementation #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batikanu
force-pushed
the
namespace-detail-resource-limits-frontend
branch
from
58ab4ea to
720bda0
Compare
Current coverage is 93.49% (diff: 100%)@@ master #1292 diff @@
==========================================
Files 366 368 +2
Lines 3037 3046 +9
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 2839 2848 +9
Misses 198 198
Partials 0 0
|
|
Please add related section to admin page. |
|
Please see #1285 for admin section. PTAL |
batikanu
force-pushed
the
namespace-detail-resource-limits-frontend
branch
from
720bda0 to
d473565
Compare
batikanu
changed the title
batikanu
changed the title
batikanu
force-pushed
the
namespace-detail-resource-limits-frontend
branch
3 times, most recently
from
d8d8f23 to
694143f
Compare
batikanu
force-pushed
the
namespace-detail-resource-limits-frontend
branch
2 times, most recently
from
14ec586 to
8756442
Compare
|
@batikanu Is this ready for review? Somehow it got stuck in our review queue and nobody looks at this. Can you rebase so that me or somebody else can review? :) Sorry for such delay, btw... |
|
Yes sure I will rebase it :) |
batikanu
force-pushed
the
namespace-detail-resource-limits-frontend
branch
from
8756442 to
b50d593
Compare
k8s-ci-robot
added
the
cncf-cla: yes
|
@bryk this should be ready for review if nothing fails in travis :) |
|
:) |
bryk
suggested changes
Nov 21, 2016
batikanu
force-pushed
the
namespace-detail-resource-limits-frontend
branch
from
b50d593 to
d65edef
Compare
|
Double header is solved and dashes are added :) |
bryk
approved these changes
Nov 22, 2016
|
LGTM! I'm sad this took so long to review... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frontend implementation for resource limits part of namespace details.
Includes also backend fixes