-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added helm chart optional containers #7554
Added helm chart optional containers #7554
Conversation
|
Welcome @daiyyr! |
Hi @maciaszczykm, comments resolved, can you please have a look again. Thank you! |
Codecov Report
@@ Coverage Diff @@
## master #7554 +/- ##
=======================================
Coverage 42.09% 42.09%
=======================================
Files 217 217
Lines 12084 12084
Branches 179 179
=======================================
Hits 5087 5087
Misses 6712 6712
Partials 285 285 |
You didn't update the version. |
Sorry misunderstood - was checking to rebase any dependency update but found none. Bumped the version to 6.0.3. |
Signed-off-by: Marcin Maciaszczyk <marcin9yk@icloud.com>
/approve |
Fixed linting error. Please tag with lgtm again |
Happy new year! When you come back from holidays, can you please review the change trying fix the linting error |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: daiyyr, maciaszczykm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Give an option for those who need auth add-ons such as keycloak