Configurable Pod Process Namespace Sharing #495

verb · 2017-10-24T12:04:43Z

Feature Description

One-line feature description (can be used as a release note): Users can configure containers within a pod to share a common PID namespace by setting an option in the PodSpec.
Primary contact (assignee): @verb
Responsible SIGs: sig-node
Kubernetes Enhancement Proposal: https://git.k8s.io/enhancements/keps/sig-node/20190920-pod-pid-namespace.md
Link to e2e and/or unit tests:
Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @yujuhong
Approver (likely from SIG/area to which feature belongs): @dchen1107
Feature target (which target equals to which milestone):
- Alpha release target (1.10)
- Beta release target (1.12)
- Stable release target (1.17)

verb · 2017-10-24T12:07:40Z

/sig node

verb · 2017-10-24T12:08:23Z

/assign @verb

zacharysarah · 2017-11-22T21:26:05Z

@verb 👋 Please indicate in the 1.9 feature tracking board
whether this feature needs documentation. If yes, please open a PR and add a link to the tracking spreadsheet. Thanks in advance!

zacharysarah · 2017-11-29T00:01:58Z

@verb Bump for docs ☝️

/cc @idvoretskyi

verb · 2017-11-30T05:28:31Z

@zacharysarah updated tracking, feature slips to 1.10

@dchen1107

Automatic merge from submit-queue (batch tested with PRs 54230, 58100, 57861, 54752). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add a feature flag for sharing process namespace between containers in a pod **What this PR does / why we need it**: This adds a feature flag for the feature described in kubernetes/enhancements#495. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: /assign @dchen1107 **Release note**: ```release-note NONE ```

jberkus · 2018-01-12T22:56:25Z

Hey, can you change the milestone for this to 1.10 so that the release team can track it properly? Thanks.

verb · 2018-01-15T11:38:03Z

@jberkus who, me? I don't think I can. At least, it's not listed as a bot command

idvoretskyi · 2018-01-22T14:49:10Z

/kind feature

verb · 2018-02-01T12:20:09Z

This feature is on track for alpha in 1.10.

If Update Container Runtime Interface to use enumerated namespace modes kubernetes#58973 and Adding support for per-pod process namespace sharing in kubelet kubernetes#59125 are accepted by sig-node, this will be available as an annotation
If Add ShareProcessNamespace to PodSpec kubernetes#58716 is accepted by API reviewer this will be accessible via the API

verb · 2018-02-27T17:04:47Z

Feature will be included as alpha in 1.10.

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add node-e2e test for ShareProcessNamespace **What this PR does / why we need it**: Adds a node-e2e test for kubernetes/enhancements#495 **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #59554 **Special notes for your reviewer**: This requires a feature gate to be enabled in both the kubelet and API server. I'm not sure which jenkins configs need to be updated (or if these are even still used) so I just updated a pile of them. opened kubernetes/test-infra#7030 for https://github.com/kubernetes/test-infra/blob/master/jobs/config.json **Release note**: ```release-note NONE ```

justaugustus · 2018-04-17T00:25:24Z

@verb
Any plans for this in 1.11?

If so, can you please ensure the feature is up-to-date with the appropriate:

Description
Milestone
Assignee(s)
Labels:
- stage/{alpha,beta,stable}
- sig/*
- kind/feature

cc @idvoretskyi

verb · 2019-10-02T11:56:19Z

KEP is https://git.k8s.io/enhancements/keps/sig-node/20190920-pod-pid-namespace.md

mrbobbytables · 2019-10-06T21:17:08Z

Thanks @verb!

irvifa · 2019-10-21T15:39:32Z

Hello @verb I'm one of the v1.17 docs shadows.
Does this enhancement for (or the work planned for v1.17) require any new docs (or modifications to existing docs)? If not, can you please update the 1.17 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, November 8th, it can just be a placeholder PR at this time. Let me know if you have any questions!

verb · 2019-10-21T15:48:23Z

@irvifa This will require a minor update of k/website to mark the feature as stable. I don't have a link to the tracker handy, so if you could update it I would appreciate it.

Ack, will open a PR against dev-1.17 by November 8.

irvifa · 2019-10-21T16:04:22Z

Hi @verb
Awesome, I already update the tracking sheet for you. Thanks for the quick response!

verb · 2019-10-25T13:12:24Z

kubernetes/kubernetes#84356 to promote to GA

verb · 2019-10-25T15:56:45Z

kubernetes/website#17192 for docs

annajung · 2019-11-06T05:04:12Z

Hey @verb 1.17 Enhancement Shadow here! 👋 I am reaching out to check in with you to see how this enhancement is going.

Thank you for providing k/k PR, I have added the following kubernetes/kubernetes#84356 in the tracking sheet. Are there any other k/k PRs that need to be tracked as well?

Also, another friendly reminder that we're quickly approaching code freeze (Nov. 14th).

verb · 2019-11-06T16:29:32Z

@annajung Thanks for checking in. We're in good shape here. The linked k/k and k/w PRs are the only ones, and all we need is final sig-node approval.

annajung · 2019-11-13T14:58:59Z

Hi @verb , Tomorrow is code freeze for 1.17 release cycle. It looks like the k/k PRs have not been merged. We’re flagging this enhancement as At Risk in the 1.17 tracking sheet.

Do you think all necessary PRs will be merged by the EoD of the 14th (Thursday)? After that, only release-blocking issues and PRs will be allowed in the milestone with an exception.

verb · 2019-11-13T15:04:09Z

@annajung the k/k PR is in the merge pool. I think it will merge.

verb · 2020-01-30T16:00:43Z

The only remaining item for this feature is to finish removing the feature gate in 1.19.

Enhancement leads: this feature should be excluded from 1.18 and included in 1.19.

palnabarun · 2020-04-29T15:46:30Z

Hi @verb, -- 1.19 Enhancements Lead here, can you confirm if the feature gate is still scheduled to be removed in 1.19?

If you do, I'll add it to the 1.19 tracking sheet (http://bit.ly/k8s-1-19-enhancements). Once the work begins please list the relevant k/k PR in this issue so it can be tracked properly. 👍

The current release schedule is:

Monday, April 13: Week 1 - Release cycle begins
Tuesday, May 19: Week 6 - Enhancements Freeze
Thursday, June 25: Week 11 - Code Freeze
Thursday, July 9: Week 14 - Docs must be completed and reviewed
Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

palnabarun · 2020-04-29T15:47:35Z

/milestone clear

(removing this issue from v1.17 milestone since the milestone is complete)

verb · 2020-04-30T14:49:29Z

@palnabarun I'm prepared to remove the feature gate, but I saw an announcement that 1.19 should avoid unnecessary backwards-incompatible changes. Could you advise on whether we should proceed with a feature gate clean up or push it to 1.20?

palnabarun · 2020-05-14T15:32:28Z

Hi @verb

We are encouraging SIGs to push for features this cycle which do not increase end-user complexity. If removing the feature gate breaks backward compatibility, I would suggest against removing it this cycle.

However, I think discussing with the SIG would be the best way to get an answer to the question.

Thanks! 👍

palnabarun · 2020-05-20T02:22:26Z

@verb -- Unfortunately, the deadline for the 1.19 Enhancement freeze has passed. For now, this is being removed from the milestone and 1.19 tracking sheet. If there is a need to get this in, please file an enhancement exception.

fejta-bot · 2020-08-18T03:01:41Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

palnabarun · 2020-09-01T14:46:06Z

/remove-lifecycle stale

verb · 2020-09-11T10:44:37Z

Looks like the PodShareProcessNamespace feature gate was removed in 1.19, anyway (#90096, @tedyu)

This feature is complete. 🎉

verb changed the title ~~Configurable Pod PID Namespace Sharing~~ Configurable per-pod PID Namespace Sharing Oct 24, 2017

k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Oct 24, 2017

k8s-ci-robot assigned verb Oct 24, 2017

idvoretskyi added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Oct 24, 2017

idvoretskyi added this to the 1.9 milestone Oct 24, 2017

bergwolf mentioned this issue Nov 28, 2017

grpc: specify if shared pidns is needed in CreateSandbox kata-containers/agent#12

Merged

zacharysarah added the do-not-merge/docs label Nov 29, 2017

verb changed the title ~~Configurable per-pod PID Namespace Sharing~~ Configurable Pod Process Namespace Sharing Jan 10, 2018

verb mentioned this issue Jan 10, 2018

Add a feature flag for sharing process namespace between containers in a pod kubernetes/kubernetes#58100

Merged

yujuhong modified the milestones: v1.9, v1.10 Jan 16, 2018

idvoretskyi removed the do-not-merge/docs label Jan 22, 2018

k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 22, 2018

idvoretskyi added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 29, 2018

verb mentioned this issue Feb 1, 2018

Use v1.Container in Debug Containers API kubernetes/community#1269

Merged

This was referenced Feb 22, 2018

Create task for alpha feature Share Process Namespace kubernetes/website#7489

Merged

Add node-e2e test for ShareProcessNamespace kubernetes/kubernetes#60509

Merged

k8s-ci-robot added this to the v1.17 milestone Sep 27, 2019

mrbobbytables added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Sep 27, 2019

verb mentioned this issue Oct 25, 2019

Ephemeral Containers #277

Closed

23 tasks

jeremyrickard removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 3, 2020

k8s-ci-robot removed this from the v1.17 milestone Apr 29, 2020

palnabarun added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label May 20, 2020

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 18, 2020

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 1, 2020

verb closed this as completed Sep 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Configurable Pod Process Namespace Sharing #495

Configurable Pod Process Namespace Sharing #495

verb commented Oct 24, 2017 •

edited

Loading

verb commented Oct 24, 2017

verb commented Oct 24, 2017

zacharysarah commented Nov 22, 2017

zacharysarah commented Nov 29, 2017

verb commented Nov 30, 2017

jberkus commented Jan 12, 2018

verb commented Jan 15, 2018

idvoretskyi commented Jan 22, 2018

verb commented Feb 1, 2018

verb commented Feb 27, 2018

justaugustus commented Apr 17, 2018

verb commented Oct 2, 2019

mrbobbytables commented Oct 6, 2019

irvifa commented Oct 21, 2019

verb commented Oct 21, 2019

irvifa commented Oct 21, 2019

verb commented Oct 25, 2019

verb commented Oct 25, 2019

annajung commented Nov 6, 2019

verb commented Nov 6, 2019

annajung commented Nov 13, 2019

verb commented Nov 13, 2019

verb commented Jan 30, 2020

palnabarun commented Apr 29, 2020

palnabarun commented Apr 29, 2020

verb commented Apr 30, 2020

palnabarun commented May 14, 2020

palnabarun commented May 20, 2020

fejta-bot commented Aug 18, 2020

palnabarun commented Sep 1, 2020

verb commented Sep 11, 2020

Configurable Pod Process Namespace Sharing #495

Configurable Pod Process Namespace Sharing #495

Comments

verb commented Oct 24, 2017 • edited Loading

Feature Description

verb commented Oct 24, 2017

verb commented Oct 24, 2017

zacharysarah commented Nov 22, 2017

zacharysarah commented Nov 29, 2017

verb commented Nov 30, 2017

jberkus commented Jan 12, 2018

verb commented Jan 15, 2018

idvoretskyi commented Jan 22, 2018

verb commented Feb 1, 2018

verb commented Feb 27, 2018

justaugustus commented Apr 17, 2018

verb commented Oct 2, 2019

mrbobbytables commented Oct 6, 2019

irvifa commented Oct 21, 2019

verb commented Oct 21, 2019

irvifa commented Oct 21, 2019

verb commented Oct 25, 2019

verb commented Oct 25, 2019

annajung commented Nov 6, 2019

verb commented Nov 6, 2019

annajung commented Nov 13, 2019

verb commented Nov 13, 2019

verb commented Jan 30, 2020

palnabarun commented Apr 29, 2020

palnabarun commented Apr 29, 2020

verb commented Apr 30, 2020

palnabarun commented May 14, 2020

palnabarun commented May 20, 2020

fejta-bot commented Aug 18, 2020

palnabarun commented Sep 1, 2020

verb commented Sep 11, 2020

verb commented Oct 24, 2017 •

edited

Loading