Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e-node test job for alpha features #7030

Merged
merged 1 commit into from
Mar 8, 2018
Merged

Add e2e-node test job for alpha features #7030

merged 1 commit into from
Mar 8, 2018

Conversation

verb
Copy link
Contributor

@verb verb commented Feb 27, 2018

This feature gate is required for test added in kubernetes/kubernetes#60509. I'm not sure which jobs should be updated, so I guessed.

/area jobs
/sig node

@k8s-ci-robot k8s-ci-robot added area/jobs sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 27, 2018
@verb verb mentioned this pull request Feb 27, 2018
Merged
@krzyzacy
Copy link
Member

/approve
please assign someone from node team to stamp

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2018
@verb
Copy link
Contributor Author

verb commented Feb 27, 2018

/cc @yujuhong

@yujuhong
Copy link
Contributor

Since this is an alpha feature, we probably don't want to enable it by default in the major kubelet e2e tests.
Could you create a new kubelet-alpha-features job instead?

@verb
Copy link
Contributor Author

verb commented Feb 28, 2018

@yujuhong SGTM

@krzyzacy if I create a new job in this file, will it automatically be run? Is this readme still accurate that I need to create the job in two places? (if not I will update the readme)

@krzyzacy
Copy link
Member

@verb I think all CI test configs are in test-infra now, I did not have time to clean up the main repo yet

@yujuhong I'm not sure what we need to keep in the main repo? Config for local run? I think I can at least get rid of all the jenkins configs?

@yujuhong
Copy link
Contributor

@yujuhong I'm not sure what we need to keep in the main repo? Config for local run? I think I can at least get rid of all the jenkins configs?

I think it should be safe to remove them. @yguo0905, is that correct?

k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this pull request Mar 5, 2018
Merge pull request #60509 from verb/pid-e2e
ae7be34 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Add node-e2e test for ShareProcessNamespace

**What this PR does / why we need it**: Adds a node-e2e test for kubernetes/enhancements#495

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #59554

**Special notes for your reviewer**: This requires a feature gate to be enabled in both the kubelet and API server. I'm not sure which jenkins configs need to be updated (or if these are even still used) so I just updated a pile of them.

opened kubernetes/test-infra#7030 for https://github.com/kubernetes/test-infra/blob/master/jobs/config.json

**Release note**:

```release-note
NONE
```
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 6, 2018
@verb verb changed the title Add ShareProcessNamespace feature to node-e2e tests Add e2e-node test job for alpha features Mar 6, 2018
@verb
Copy link
Contributor Author

verb commented Mar 6, 2018

@yujuhong I updated this to include a test for alpha features. Rather than constraining to tests marked alpha, it runs all of the (non-serial) tests since it's useful to know if an alpha feature breaks other tests or even if a stable change breaks an alpha feature.

The RotateKubeletServerCertificate feature is disabled since it doesn't currently pass e2e-node. If this PR is submitted I'll open an issue to the owner to fix it.

PTAL.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 6, 2018
@verb
Copy link
Contributor Author

verb commented Mar 6, 2018

Hrmm, the test failed because I didn't add it to any dashboards in testgrid. I'm not exactly sure where it should go, so I'll hold off on this until I get feedback on the approach.

@krzyzacy
Copy link
Member

krzyzacy commented Mar 6, 2018

@verb basically follow https://github.com/kubernetes/test-infra#create-a-new-job, testgrid config goes to https://github.com/kubernetes/test-infra/blob/master/testgrid/config.yaml

@krzyzacy
Copy link
Member

krzyzacy commented Mar 6, 2018

/assign

@verb verb requested a review from michelle192837 as a code owner March 8, 2018 14:44
@verb
Copy link
Contributor Author

verb commented Mar 8, 2018

@yujuhong suggested placing this on the sig-node dashboard, so I've added it to the existing sig-node-kubelet. Tests are passing now.

@krzyzacy
Copy link
Member

krzyzacy commented Mar 8, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krzyzacy, verb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 691b6e8 into kubernetes:master Mar 8, 2018
@k8s-ci-robot
Copy link
Contributor

@verb: Updated the config configmap

In response to this:

This feature gate is required for test added in kubernetes/kubernetes#60509. I'm not sure which jobs should be updated, so I guessed.

/area jobs
/sig node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@verb verb mentioned this pull request Mar 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@krzyzacy krzyzacy Awaiting requested review from krzyzacy

@yujuhong yujuhong Awaiting requested review from yujuhong

@michelle192837 michelle192837 Awaiting requested review from michelle192837

Assignees

@krzyzacy krzyzacy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@verb @krzyzacy @yujuhong @k8s-ci-robot