sig-api-machinery: port CRD conversion webhook design doc to KEP, add v1beta1 criteria #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
size/XL
sttts
reviewed
Apr 26, 2019
roycaihw
reviewed
Apr 26, 2019
roycaihw
reviewed
Apr 26, 2019
jpbetz
force-pushed
the
crd-conversion-webhook-kep
branch
2 times, most recently
from
fcf31d7 to
acae11e
Compare
roycaihw
reviewed
Apr 29, 2019
|
/lgtm |
k8s-ci-robot
added
the
lgtm
sttts
reviewed
Apr 29, 2019
sttts
reviewed
Apr 29, 2019
sttts
reviewed
Apr 29, 2019
liggitt
reviewed
Apr 29, 2019
liggitt
reviewed
Apr 29, 2019
liggitt
reviewed
Apr 29, 2019
jpbetz
force-pushed
the
crd-conversion-webhook-kep
branch
from
acae11e to
ae54106
Compare
k8s-ci-robot
removed
the
lgtm
liggitt
reviewed
Apr 29, 2019
jpbetz
force-pushed
the
crd-conversion-webhook-kep
branch
2 times, most recently
from
7ee5554 to
95951eb
Compare
jpbetz
force-pushed
the
crd-conversion-webhook-kep
branch
from
95951eb to
ea54497
Compare
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpbetz, lavalamp, liggitt, roycaihw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We intend to promote CRD conversion webhooks to v1beta1 in Kubernetes 1.15.
Since we typically document criteria in the KEP, I'm first porting the existing customresource-conversion-webhook.md design doc from kubernetes/community to a KEP.
See graduation criteria section of the v1beta1 criteria, which I've added in a separate commit in this PR.