Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sig-release: Add release cadence KEP #2567

Merged
merged 34 commits into from
Apr 23, 2021
Merged

sig-release: Add release cadence KEP #2567

merged 34 commits into from
Apr 23, 2021

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Mar 12, 2021 •
edited
Loading

Enhancement tracking issue: #2572

Signed-off-by: Stephen Augustus foo@auggie.dev

cc: @kubernetes/sig-release-leads @kubernetes/sig-architecture-leads @kubernetes/sig-testing-leads

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 12, 2021
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Mar 12, 2021
@k8s-ci-robot k8s-ci-robot requested a review from hasheddan March 12, 2021 14:32
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 12, 2021
@justaugustus justaugustus mentioned this pull request Mar 12, 2021
Closed
@justaugustus justaugustus changed the title sig-release: Add release cadence KEP [WIP] sig-release: Add release cadence KEP Mar 12, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 12, 2021
@fejta-bot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.
/check-cla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 12, 2021
@justaugustus justaugustus mentioned this pull request Mar 15, 2021
Closed
4 tasks
@justaugustus justaugustus added this to the v1.22 milestone Mar 15, 2021
@justaugustus justaugustus mentioned this pull request Mar 15, 2021
Closed
lasomethingsomething
lasomethingsomething reviewed Mar 15, 2021
View reviewed changes
keps/sig-release/2572-release-cadence/README.md Outdated Show resolved Hide resolved
keps/sig-release/2572-release-cadence/README.md Outdated Show resolved Hide resolved
keps/sig-release/2572-release-cadence/README.md Outdated Show resolved Hide resolved
keps/sig-release/2572-release-cadence/README.md Outdated Show resolved Hide resolved
keps/sig-release/2572-release-cadence/README.md Outdated Show resolved Hide resolved
@justaugustus justaugustus force-pushed the cadence branch 2 times, most recently from 3607cbf to dd9ae18 Compare March 17, 2021 17:19
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 24, 2021
@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2021
@justaugustus
sig-release/2572-release-cadence: Initial commit
cfe59ef 
Signed-off-by: Stephen Augustus <foo@auggie.dev>
@saschagrunert
Copy link
Member

@jeremyrickard looks like one discussion needs to be closed. left a note there.

Created an issue in SIG release to keep track of the survey and resolved the discussion for now.

Thank you for all the feedback, reviewers! 🙏 Let's please focus on getting this KEP done and framed to its current scope. We can open broader issues/discussions in SIG release for follow-ups. For example, we already have a discussion about "releasing faster" there: kubernetes/sig-release#1495

@saschagrunert saschagrunert mentioned this pull request Apr 19, 2021
Open
@dims
Copy link
Member

dims commented Apr 19, 2021

/approve
/hold for all approvers to cast their vote/support.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2021
@saschagrunert saschagrunert mentioned this pull request Apr 20, 2021
Merged
xmudrii
xmudrii reviewed Apr 20, 2021
View reviewed changes
keps/sig-release/2572-release-cadence/README.md Outdated Show resolved Hide resolved
keps/sig-release/2572-release-cadence/README.md
Comment on lines +404 to +405
2. The last Kubernetes release of a year should be finished by the middle of
December.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In regards to comments from @jberkus and @liggitt (#2567 (comment)), I think that this should be defined more precisely. I think that choosing something like December 10th (as proposed by @liggitt) makes sense.

@jeremyrickard
Amend 2022 dates
41d22d3 
Signed-off-by: Jeremy <jeremyrrickard@gmail.com>
@jeremyrickard
review comment cleanup
2887453 
Signed-off-by: Jeremy <jeremyrrickard@gmail.com>
@derekwaynecarr
Copy link
Member

put my sig-node and sig-arch hat on. agree with the 12/10 proposal from @liggitt

/approve

@jberkus
Copy link
Contributor

jberkus commented Apr 20, 2021

Per SIG-Release meeting this AM:

/lgtm (non-binding)

@johnbelamaric
Copy link
Member

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2021
@github-actions github-actions bot mentioned this pull request Apr 21, 2021
Open
@dchen1107
Copy link
Member

/approve

@dims
Copy link
Member

dims commented Apr 22, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 22, 2021
@saschagrunert
Copy link
Member

Still waiting for approval from @kubernetes/sig-testing

@saschagrunert
Copy link
Member

Applying a lazy consensus until next Wednesday, April 28 at 4pm US eastern time.

Ref: https://groups.google.com/g/kubernetes-sig-release/c/e8c72aKMHOo/m/18k62IxtAQAJ

spiffxp
spiffxp approved these changes Apr 23, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
As SIG Testing chair

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, derekwaynecarr, dims, johnbelamaric, justaugustus, nikopen, saschagrunert, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sftim
Copy link
Contributor

sftim commented Apr 23, 2021

LGTM
Informal, lazy consensus for SIG Docs

@justaugustus
Copy link
Member Author

justaugustus commented Apr 23, 2021 •
edited
Loading

Hearing approvals from @kubernetes/sig-release-leads and each of the approving groups:

A lazy consensus timeout is no longer required.

Thank you to everyone in the community who has provided feedback for this KEP!

FYI @kubernetes/sig-release
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 23, 2021
@justaugustus justaugustus removed the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit 74dbf2d into kubernetes:master Apr 23, 2021
@justaugustus
Copy link
Member Author

Announcement sent to k-announce, k-dev, CNCF maintainers, and the CNCF TOC: https://groups.google.com/g/kubernetes-announce/c/is_pjOd5hho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekwaynecarr derekwaynecarr derekwaynecarr left review comments

@kikisdeliveryservice kikisdeliveryservice kikisdeliveryservice left review comments

@thockin thockin thockin left review comments

@dims dims dims left review comments

@lasomethingsomething lasomethingsomething lasomethingsomething left review comments

@youngnick youngnick youngnick left review comments

@liggitt liggitt liggitt left review comments

@xmudrii xmudrii xmudrii left review comments

@howardjohn howardjohn howardjohn left review comments

@jberkus jberkus jberkus left review comments

@sftim sftim sftim left review comments

@aojea aojea aojea left review comments

@palnabarun palnabarun palnabarun left review comments

@wojtek-t wojtek-t wojtek-t left review comments

@cblecker cblecker cblecker left review comments

@ehashman ehashman ehashman left review comments

@nikopen nikopen nikopen approved these changes

@spiffxp spiffxp spiffxp approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@alejandrox1 alejandrox1 Awaiting requested review from alejandrox1

@hasheddan hasheddan Awaiting requested review from hasheddan

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

Assignees

@dims dims

@spiffxp spiffxp

@BenTheElder BenTheElder

@ehashman ehashman

@derekwaynecarr derekwaynecarr

@stevekuznetsov stevekuznetsov

@johnbelamaric johnbelamaric

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.