KEP-3386: Add Beta (enabled by default) criteria for Evented PLEG #3900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
harche
commented
Mar 7, 2023
harche
commented
- One-line PR description: Add a GA criteria for Evented PLEG based on discussion Graduate Evented PLEG to Beta kubernetes#115967 (comment)
- Issue link: Kubelet Evented PLEG for Better Performance #3386
- Other comments:
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
kind/kep
k8s-ci-robot
added
size/M
harche
force-pushed
the
ga_criteria
branch
2 times, most recently
from
16ce7b9 to
c0a3bc9
Compare
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
harche
changed the title
harche
force-pushed
the
ga_criteria
branch
3 times, most recently
from
c78667f to
7b479b2
Compare
harche
commented
Mar 10, 2023
Signed-off-by: Harshal Patil <harpatil@redhat.com>
SergeyKanzhelev
approved these changes
Mar 10, 2023
There was a problem hiding this comment.
/lgtm
/assign @dchen1107
@dchen1107 I believe these tests will cover Evented PLEG once we decide to enable it be default.
k8s-ci-robot
added
the
lgtm
|
/lgtm Thanks for the follow up with KEP proposal, and very glad to have this for another beta (default on). |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dchen1107, harche, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.