Support PSI based on cgroupv2

[ndixita]

Enhancement Description

• One-line enhancement description (can be used as a release note): Integrating PSI metrics in K8s and using those to set node conditions.
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/4205-psi-metric/README.md
• Discussion Link:
• Primary contact (assignee): @ndixita
• Responsible SIGs: sig-node
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.32 (waiting for runc 1.2.0 release)
  • Beta release target (x.y):
  • Stable release target (x.y):
• Alpha
  • KEP (k/enhancements) update PR(s):
    • 1.29: KEP-4205: KEP to add PSI metrics in Summary API, and for PSI based node actions #4230
    • 1.30: KEP-4025: several formatting fixes #4360
    • 1.30: KEP-4205: updating the milestone for alpha to 1.30 #4454
    • 1.32: 4205: retarget to 1.32 #4883
  • Code (k/k) update PR(s):
    • 1.32 vendor: bump runc/libcontainer to v1.2.1 kubernetes#128276
    • [NOT FOR REVIEW ] In Progress PSI POC  kubernetes#118266
  • Docs (k/website) update PR(s): KEP 4205: draft PR for PSI KEP website#48468

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[pacoxu]

/sig node

[SergeyKanzhelev]

/milestone v1.29
/label lead-opted-in
/stage alpha

@ndixita please fill up more details in the issue description. Accepting as we discussed at SIG Node meeting this week

[tzneal]

/cc

[rayandas]

Hello @ndixita 👋, v1.29 Enhancements team here.

Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.

This enhancement is targeting for stage alpha for v1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: 1.29.
• KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

• The latest readme template has more items in production readiness review questionnaire that need to be addressed.
• The status should be marked as implementable in the kep.yaml file.
• Ensure that the PR including the production readiness review has been reviewed and merged into k/enhancements.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[rayandas]

Hi @ndixita 👋🏽 checking in once more as we approach the 1.29 enhancement freeze deadline on 01:00 UTC, Friday, 6th October, 2023. The status of this enhancement is marked as at risk for enhancement freeze.
It looks like PR #4230 will address most of the requirements. Let me know if I missed anything. Thanks.

[ndixita]

The KEP PR is updated, and the comments are resolved. I am waiting for PRR review

[npolshakova]

With KEP PR #4230 approved, the enhancement is ready for the enhancements freeze. The status is now marked as tracked for enhancement freeze for 1.29. 🚀 Thank you!

[katcosgrove]

Hey there @ndixita! 👋, v1.29 Docs Lead here.
Does this enhancement work planned for v1.29 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

[katcosgrove]

Hi again @ndixita! The deadline to open a placeholder PR against k/website for required documentation is this Thursday, 19 October. Could you please update me on the status of docs for this enhancement? Thank you!

[rayandas]

Hey again @ndixita 👋, 1.29 Enhancements team here,

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November 2023: .

Here's where this enhancement currently stands:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).

• All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

Please update the Issue description to include all the related PRs of this KEP under the stable section in the Github Issue description. The status for this KEP is currently at risk for code freeze.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.

As always, we are here to help if any questions come up. ✌️ Thanks!

[a-mccarthy]

Hi @ndixita, 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository.
The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here is the 1.29 calendar

[ndixita]

@a-mccarthy This feature is postponed to 1.30 release

[npolshakova]

Hello @ndixita 👋 1.29 Enhancements lead here,

Unfortunately, the implementation (code related) PR(s) associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the 1.29 milestone.

If you still wish to progress this enhancement in 1.29, please file an exception request. Thanks!

/milestone clear

[amannijhawan]

This would be quite useful to have as we can use the psi metrics as a good proxy for memory pressure and potential for OOMKILL.

Thanks
Aman

[haircommander]

I've opened a PR for this in #4883

[kannon92]

@ndixita can you update the KEP description with #4883.

I think that we can considering this tracked for enhancement freeze otherwise.

[haircommander]

done, thanks @kannon92 !

[dipesh-rawat]

Hello @ndixita 👋, v1.32 Enhancements team here,

Now that PR #4883 has been merged, all the KEP requirements are in place and merged into k/enhancements.

The status of this enhancement is now marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[pacoxu]

opencontainers/runc#4114 is tracking the runc 1.2.0 blockers. xpost here.

[hacktivist123]

Hello @ndixita 👋 1.32 Docs Shadow here.

Does this enhancement work planned for 1.32 require any new docs or modifications to existing docs?
If so, please follow the steps here to open a PR against the dev-1.32 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, October 24th 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

[rytswd]

Hi @ndixita 👋 -- this is Ryota (@rytswd) from the v1.32 Communications Team!

For the v1.32 release, we are currently in the process of collecting and curating a list of potential feature blogs, and we'd love for you to consider writing one for your enhancement!

As you may be aware, feature blogs are a great way to communicate to users about features which fall into (but not limited to) the following categories:

• This introduces some breaking change(s)
• This has significant impacts and/or implications to users
• ...Or this is a long-awaited feature, which would go a long way to cover the journey more in detail 🎉

To opt in to write a feature blog, could you please let us know and open a "Feature Blog placeholder PR" (which can be only a skeleton at first) against the website repository by Wednesday, 30th Oct 2024? For more information about writing a blog, please find the blog contribution guidelines 📚

Tip

Some timeline to keep in mind:

• 02:00 UTC Wednesday, 30th Oct: Feature blog PR freeze
• Monday, 25th Nov: Feature blogs ready for review
• You can find more in the release document

Note

In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

[hacktivist123]

Hello, @ndixita 👋 1.32 Docs Shadow here.

This is just a reminder to open a placeholder PR against dev-1.32 branch in the k/website repo for this (steps available here) for this KEP if it requires new or modifications to existing docs:

The deadline for this is Thursday, Oct 24 at 18:00 PDT.
Thanks! 🚀

[dipesh-rawat]

Hey again @ndixita 👋 v1.32 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Friday 8th November 2024 / 19:00 PDT Thursday 7th November 2024 .

Here's where this enhancement currently stands:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

I searched k/k and couldn’t find any recent PRs related to this KEP.

@ndixita Please let me know the PRs in k/k that are not listed in the description or not linked with this GitHub issue that we need to track for this KEP, so that we can maintain accurate status.

The status of this enhancement is marked as at risk for code freeze.

If you anticipate missing code freeze, you can file an exception request in advance. Thank you!

[kannon92]

Hey release team.

This one is a bit tricky to document. Runc does not have a 1.2 release yet. If we get one in the next week, we could maybe actually have code changes for this.

But until that, I don't think we should open a doc PR yet.

[haircommander]

opened a draft PR sorry for the delay kubernetes/website#48468

[pacoxu]

Some update from cadvisor\runc\containerd:

• Runc 1.2.0(will be released soon) libct/cg/stats: support PSI for cgroup v2 opencontainers/runc#3900 libct/cg/stats: support PSI for cgroup v2 KEP-3386: Add Beta (enabled by default) criteria for Evented PLEG #3900
• [WIP] Support for exposing PSI metrics google/cadvisor#3083
• Containerd 2.0 only(not included in v1.7 containerd) containerd/cgroups: support PSI: build(deps): bump github.com/containerd/cgroups/v3 from 3.0.2 to 3.0.3 #9583

Waiting for runc 1.2.0. https://github.com/opencontainers/runc/milestone/13

https://github.com/opencontainers/runc/releases/tag/v1.2.0 is released today.

• I opened bump runc to v1.2.0 kubernetes#128261 to bump runc and the cadvisor PR Support for exposing PSI metrics  google/cadvisor#3083 needs to bump runc as well.

[rytswd]

Hi @ndixita 👋, v1.32 Communications Team here again!

This is a gentle reminder for the feature blog deadline mentioned above, which is 02:00 UTC Wednesday, 30th Oct. To opt in, please let us know and open a Feature Blog placeholder PR against k/website by the deadline. If you have any questions, please feel free to reach out to us!

Tip

Some timeline to keep in mind:

• 02:00 UTC Wednesday, 30th Oct: Feature blog PR freeze
• Monday, 25th Nov: Feature blogs ready for review
• You can find more in the release document

Note

In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

[pacoxu]

https://github.com/opencontainers/runc/releases/tag/v1.2.0 is released today.

• I opened bump runc to v1.2.0 kubernetes#128261 to bump runc and the cadvisor PR Support for exposing PSI metrics  google/cadvisor#3083 needs to bump runc as well.

kubernetes/kubernetes#128276 was merged.

[dipesh-rawat]

Hey again @ndixita 👋, v1.32 Enhancements team here,

Just a quick friendly reminder as we approach code freeze in few days, at 02:00 UTC Friday 8th November 2024 / 19:00 PDT Thursday 7th November 2024 .

The current status of this enhancement is marked as at risk for code freeze. There are a few requirements mentioned in the comment #4205 (comment) that still need to be completed.

If you anticipate missing code freeze, you can file an exception request in advance.

[dipesh-rawat]

Hello @ndixita 👋 v1.32 Enhancements team here,

Unfortunately, the implementation (code related) PR(s) associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the v1.32 milestone.

If you still wish to progress this enhancement in v1.32, please file an exception request as soon as possible, within three days. If you have any questions, you can reach out in the #release-enhancements channel on Slack and we'll be happy to help. Thanks!

/label tracked/no
/remove-label tracked/yes
/milestone clear