-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-4205: updating the milestone for alpha to 1.30 #4454
Conversation
ndixita
commented
Jan 29, 2024
•
edited
Loading
edited
- One-line PR description: This KEP lays the initial foundations to use PSI metrics for setting Node Conditions.
- Issue link: Support PSI based on cgroupv2 #4205
/milestone v1.30 |
@ndixita: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4c08512
to
4907f0f
Compare
Should this be updated also? So are we able to implement this in 1.30 or are we waiting for a runc change? It may be worth calling that out somewhere (maybe in the KEP issue?) |
Signed-off-by: ndixita <ndixita@google.com>
Done! Added the details in the question related to dependencies. |
thank you @ndixita! Looking forward to this one! /lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrunalp, ndixita The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |