Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

promote ServiceNodePortStaticSubrange to stable #4158

Merged
merged 1 commit into from
Aug 25, 2023
Merged

promote ServiceNodePortStaticSubrange to stable #4158

merged 1 commit into from
Aug 25, 2023

Conversation

xuzhenglun
Copy link
Contributor

  • One-line PR description: KEP-3668: promote to stable
  • Other comments:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Aug 22, 2023
@k8s-ci-robot k8s-ci-robot requested review from dcbw and shaneutt August 22, 2023 06:20
@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 22, 2023
@xuzhenglun xuzhenglun mentioned this pull request Aug 22, 2023
Closed
16 tasks
@xuzhenglun
Copy link
Contributor Author

/assign @wojtek-t @thockin @aojea

There is no issues reported AFAIK, promote this to stable in 1.29.

@aojea
Copy link
Member

aojea commented Aug 22, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2023
wojtek-t
wojtek-t reviewed Aug 24, 2023
View reviewed changes
Copy link
Member

@wojtek-t wojtek-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment from PRR side - other than that LGTM.

keps/sig-network/3668-reserved-service-nodeport-range/README.md
- No issues reported during two releases.
- No issues reported during one release. This is because the feature is built on the top of
[ServiceIPStaticSubrange](https://kep.k8s.io/3070), which has been GA since v1.26.
Consequently, there is no need for any additional probation period.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't comment on unchanged lines, so commenting here:

L367: have those metrics been added? If so, please update, if not, I would like to see them added before approving GA graduation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, those metrics have been added in 1.27.
https://github.com/kubernetes/kubernetes/pull/114418/files#diff-5532df35d48ad268e48b9761bd16d6c1204a7fa05cfd97afffcf47008ba012f7R31

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update the wording in the PRR to reflect that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's updated.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 25, 2023
@wojtek-t
Copy link
Member

Thanks - this LGTM from PRR perspective.

/lgtm
/approve PRR

@thockin - requires your SIG approval
/assign @thockin

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 25, 2023
thockin
thockin reviewed Aug 25, 2023
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, thockin, wojtek-t, xuzhenglun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1202981 into kubernetes:master Aug 25, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtek-t wojtek-t wojtek-t left review comments

@aojea aojea aojea left review comments

@thockin thockin thockin left review comments

@dcbw dcbw Awaiting requested review from dcbw

@shaneutt shaneutt Awaiting requested review from shaneutt

Assignees

@thockin thockin

@aojea aojea

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.
5 participants
@xuzhenglun @aojea @wojtek-t @k8s-ci-robot @thockin