Correctly format ipv6 resolver config for lua #3895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/lgtm |
k8s-ci-robot
added
lgtm
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
@jacksontj please also change |
k8s-ci-robot
added
size/M
|
@aledbf I'm not sure what you are referring to-- that is the method I changed. I did notice that the next method down (buildResolvers) has the correct logic, so I made mine look the same -- but there is no functional difference. Is that what you were referring to? Or is there something else? |
k8s-ci-robot
added
size/S
aledbf
removed
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi, jacksontj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jacksontj
added a commit
to jacksontj/ingress-nginx
that referenced
this pull request
Sep 7, 2019
It seems that when support was added for parsing resolv_conf directly a regression was introduced which effectively breaks anyone with ipv6 resolvers. Regression of kubernetes#3895
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Fix for #3881 by correctly formatting ipv6 resolver addresses for lua.
There was some discussion RE this fix in #3882 as well