-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly format ipv6 resolver config for lua #4543
Conversation
It seems that when support was added for parsing resolv_conf directly a regression was introduced which effectively breaks anyone with ipv6 resolvers. Regression of kubernetes#3895
Hi @jacksontj. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @aledbf |
I have tested this on my ipv4 and ipv6-only clusters (done so by mounting the lua file over the existing one). |
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## master #4543 +/- ##
==========================================
+ Coverage 59.05% 59.06% +0.01%
==========================================
Files 89 89
Lines 6811 6811
==========================================
+ Hits 4022 4023 +1
- Misses 2350 2351 +1
+ Partials 439 437 -2
Continue to review full report at Codecov.
|
/lgtm |
@jacksontj thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, jacksontj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
regression test for the issue fixed in #4543
It seems that when support was added for parsing resolv_conf directly a regression was introduced which effectively breaks anyone with ipv6 resolvers.
Regression of #3895