Adding annotations for HPA

[njegosrailic]

What this PR does / why we need it:

• Adding option to set annotations on HPA object

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added tests to cover my changes.
• All new and existing tests passed.

[k8s-ci-robot]

Welcome @njegosrailic!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @njegosrailic. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tao12345666333]

/ok-to-test

[tao12345666333]

/lgtm

[cpanato]

thanks, lgtm in general

need to bump the chart version and add the change in the changelog

[strongjz]

@njegosrailic Here is an example of what @cpanato is talking about https://github.com/kubernetes/ingress-nginx/pull/7024/files

[cpanato]

thanks @strongjz, i was not clear :(

[strongjz]

thanks @strongjz, i was not clear :(

No worries, I've documented this process now so other contributors can see it. #7125

[njegosrailic]

Thanks for taking a look. It should be all set. My apologies for the delay.

[njegosrailic]

A similar change related to startup probes was merged today so I have removed that part from my PR.

[tao12345666333]

can you squash your commits?

[tao12345666333]

/lgtm

[njegosrailic]

@rikatz When you got a minute could you please review this change?
Thanks!

[cpanato]

/lgtm
/approve

[rikatz]

If Carlos approves then I approve :)

/approve
/lgtm
Thanks!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, njegosrailic, rikatz, tao12345666333, tokers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• charts/ingress-nginx/OWNERS [rikatz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment