Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving k8s-artifacts-gcslogs bucket to its own project #1968

Closed
riaankleinhans opened this issue Apr 22, 2021 · 21 comments
Closed

Moving k8s-artifacts-gcslogs bucket to its own project #1968

riaankleinhans opened this issue Apr 22, 2021 · 21 comments
Assignees
Labels
area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/audit Audit of project resources, audit followup issues, code in audit/ priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@riaankleinhans
Copy link
Contributor

riaankleinhans commented Apr 22, 2021

ii.coop request access to the k8s-artifacts-gcslogs to work on K8s Infra WG projects
Granting access with the correct level of permission proof to be difficult.

If the bucket is in its own project it need not pick up projectOwners
Bindings is a cleaner solution to accomplish

Fixes issue: #1945
Refers to PR:
Read access to read access k8s-artifacts-gcslogs #1966
Enable GCS logs #904

@riaankleinhans
Copy link
Contributor Author

/assign @ameukam @spiffxp
/cc @hh

@ameukam ameukam added area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/audit Audit of project resources, audit followup issues, code in audit/ priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. wg/k8s-infra labels Apr 23, 2021
@ameukam ameukam added this to the v1.22 milestone Apr 23, 2021
@riaankleinhans
Copy link
Contributor Author

k8s-artifacts-gcslogs bucket access available to ii
Thank you @spiffxp @ameukam

@ameukam
Copy link
Member

ameukam commented May 14, 2021

/reopen
I'll consider this done when #2031 is merged. I plan to do the transition to the dedicated project next week.

@k8s-ci-robot
Copy link
Contributor

@ameukam: Reopened this issue.

In response to this:

/reopen
I'll consider this done when #2031 is merged. I plan to do the transition to the dedicated project next week.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp
Copy link
Member

spiffxp commented Jul 9, 2021

/assign @hh
I'm assigning @hh for awareness, but I think this is something that @ameukam and I can handle. We just might someone from ii to confirm that they are capable of polling/regenerating their reports at the end of this.

My sketch of a plan:

@ameukam
Copy link
Member

ameukam commented Jul 13, 2021

We will need to migrate the BigQuery datasets used for images pulling reports.
@Riaankl @bernokl Can you provide us the list of datasets that need to be migrated ?

@riaankleinhans
Copy link
Contributor Author

@ameukam I cleaned up the k8s-infra-ii-sandbox with only 2 data sets remaining:

  • riaan_data_store
  • etl_script_generated_set_prod
    These we need for reports

@ameukam
Copy link
Member

ameukam commented Jul 21, 2021

@Riaankl Do you need those buckets to be migrated :

cloud alpha storage ls --project k8s-infra-ii-sandbox
gs://artifacts.k8s-infra-ii-sandbox.appspot.com/
gs://export-c2e4nmc5jmg9n5nacc60/
gs://ii_bq_scratch_dump/
gs://k8s-infra-ii-sandbox-bb-test/

Apart from all this, is there anything else that needs to be migrated ?
cc @bernokl

@riaankleinhans
Copy link
Contributor Author

@Riaankl Do you need those buckets to be migrated :

cloud alpha storage ls --project k8s-infra-ii-sandbox
gs://artifacts.k8s-infra-ii-sandbox.appspot.com/
gs://export-c2e4nmc5jmg9n5nacc60/
gs://ii_bq_scratch_dump/
gs://k8s-infra-ii-sandbox-bb-test/

@ameukam Yes, please.

ameukam added a commit to ameukam/k8s.io that referenced this issue Aug 2, 2021
Ref: kubernetes#1968

Allow Read-only access to BigQuery data `riaan_data_store`.

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@spiffxp
Copy link
Member

spiffxp commented Aug 6, 2021

/milestone v1.23

@k8s-ci-robot k8s-ci-robot removed this from the v1.22 milestone Aug 6, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 6, 2021
ameukam added a commit to ameukam/k8s.io that referenced this issue Aug 17, 2021
Ref: kubernetes#1968

Grant this role allow the BigQuery Data transfer `BigQuery Data Transfer
to k8s_infra_artifacts_gcslogs` to run successfully.

By fixing the typo in the name of the transfer job, I'm forced to
recreate the job which means change the start date.

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@spiffxp
Copy link
Member

spiffxp commented Sep 2, 2021

/remove-priority important-longterm
/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Sep 2, 2021
@spiffxp
Copy link
Member

spiffxp commented Sep 9, 2021

Migrating files from the old bucket to the new bucket via

gsutil -m rsync gs://k8s-artifacts-gcslogs gs://k8s-infra-artifacts-gcslogs

This looks like it will take ~3h and transfer 2.2TB of data across ~325k files

@spiffxp
Copy link
Member

spiffxp commented Sep 9, 2021

Done migrating data over

[323.5k/323.5k files][  2.2 TiB/  2.2 TiB] 100% Done 671.9 MiB/s ETA 00:00:00
Operation completed over 323.5k objects/2.2 TiB.

@spiffxp
Copy link
Member

spiffxp commented Sep 9, 2021

@BobyMCbobs @Riaankl can you confirm you're reading from gs://k8s-infra-artifacts-gcslogs and that it's safe to delete gs://k8s-artifacts-gcslogs?

@BobyMCbobs
Copy link
Member

BobyMCbobs commented Sep 10, 2021

@BobyMCbobs @Riaankl can you confirm you're reading from gs://k8s-infra-artifacts-gcslogs
Yes! Permissions are sorted, thank you 😃

and that it's safe to delete gs://k8s-artifacts-gcslogs?
I will have to defer back to @Riaankl for Monday (NZDT), to ensure things are all pulled across and referenced correctly.

Cheers, @spiffxp!

@riaankleinhans
Copy link
Contributor Author

@BobyMCbobs now that you have pipeline off log data establish we do not need any older data.

@spiffxp
Copy link
Member

spiffxp commented Sep 13, 2021

I don't follow if the above comment means we're OK to delete the old bucket, can you please clarify?

@riaankleinhans
Copy link
Contributor Author

I don't follow if the above comment means we're OK to delete the old bucket, can you please clarify?

From my side, yes you can delete, Thank you.

@spiffxp
Copy link
Member

spiffxp commented Sep 13, 2021

$ time gsutil -mq rm -r gs://k8s-artifacts-gcslogs

real	51m27.627s
user	28m47.162s
sys	12m52.428s

@spiffxp
Copy link
Member

spiffxp commented Sep 14, 2021

/close
Saw an audit PR confirm the bucket is gone. Calling this done.

@k8s-ci-robot
Copy link
Contributor

@spiffxp: Closing this issue.

In response to this:

/close
Saw an audit PR confirm the bucket is gone. Calling this done.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ameukam added a commit to ameukam/k8s.io that referenced this issue Feb 6, 2023
gs://k8s-artifacts-gcslogs have been deleted. See: kubernetes#1968 (comment)
Removing the binding to a deleted resource.

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/audit Audit of project resources, audit followup issues, code in audit/ priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

6 participants