gcp/bash/prod: ensure gcs logs for prod buckets #2680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apparently some of these buckets had gcs access logs manually enabled, so they never migrated to the new gcs bucket we've used for gcs access logs
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
area/bash
spiffxp
commented
Sep 9, 2021
Comment on lines
+119
to
+120
| color 6 "Ensuring GCS access logs enabled for GCR bucket in region: ${region} in project: ${project}" | ||
| ensure_gcs_bucket_logging "${gcr_bucket}" |
There was a problem hiding this comment.
This is the addition that matters for the GCR repo, the rest of this diff is merging the three regional loops into one
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Ran |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
apparently some of these buckets had gcs access logs manually enabled,
so they never migrated to the new gcs bucket we've used for gcs access
logs