-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster-api-provider-openstack delete conformance bucket #1807
cluster-api-provider-openstack delete conformance bucket #1807
Conversation
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need this bucket anymore as we migrated from OpenLab to Prow.
3f578ff
to
5f3d1f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ah the joys of permissions...
I'll keep poking |
Oh sorry :). Could also schedule a task for 2030 :) Thank you! |
# $ gsutil iam get gs://k8s-conform-capi-openstack | json2yaml
bindings:
- members:
- group:k8s-infra-artifact-admins@kubernetes.io
- projectEditor:k8s-conform
- projectOwner:k8s-conform
role: roles/storage.legacyBucketOwner
- members:
- projectViewer:k8s-conform
role: roles/storage.legacyBucketReader
- members:
- group:k8s-infra-conform-capi-openstack@kubernetes.io
role: roles/storage.legacyBucketWriter
- members:
- group:k8s-infra-artifact-admins@kubernetes.io
- group:k8s-infra-conform-capi-openstack@kubernetes.io
role: roles/storage.objectAdmin
- members:
- serviceAccount:service-capi-openstack@k8s-conform.iam.gserviceaccount.com
role: roles/storage.objectCreator
- members:
- allUsers
role: roles/storage.objectViewer
OK that should do it |
We don't need this bucket anymore as we migrated from OpenLab to Prow.
I'm not sure how I'm actually deleting this bucket in if this PR is correct.
I assume just because I delete the config the resources are not automatically deleted.
I'm also not sure what the policy is. We won't use this bucket from now on, but it contains old
conformance test results. I assume nobody needs them anymore.
xrefs: