Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster-api-provider-openstack delete conformance bucket #1807

Merged

Conversation

sbueringer
Copy link
Member

We don't need this bucket anymore as we migrated from OpenLab to Prow.

I'm not sure how I'm actually deleting this bucket in if this PR is correct.
I assume just because I delete the config the resources are not automatically deleted.

I'm also not sure what the policy is. We won't use this bucket from now on, but it contains old
conformance test results. I assume nobody needs them anymore.

xrefs:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/audit Audit of project resources, audit followup issues, code in audit/ wg/k8s-infra labels Mar 19, 2021
@k8s-ci-robot k8s-ci-robot requested review from nikhita and spiffxp March 19, 2021 09:14
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 19, 2021
@spiffxp
Copy link
Member

spiffxp commented Mar 23, 2021

/assign

Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct that deletion is at present manual. Myself, @ameukam or @dims can do this.

Before we do, can you update your PR to remove this line from this file?

We don't need this bucket anymore as we migrated from OpenLab to Prow.
@sbueringer sbueringer force-pushed the pr-drop-capo-conformance-bucket branch from 3f578ff to 5f3d1f5 Compare March 23, 2021 20:20
@sbueringer
Copy link
Member Author

You are correct that deletion is at present manual. Myself, @ameukam or @dims can do this.

Before we do, can you update your PR to remove this line from this file?

Ah missed that one. Fixed & push force'd (I assume squash before merge is required anyway)

Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2021
@k8s-ci-robot k8s-ci-robot merged commit 629ffd7 into kubernetes:main Mar 24, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 24, 2021
@sbueringer sbueringer deleted the pr-drop-capo-conformance-bucket branch March 24, 2021 17:48
@spiffxp
Copy link
Member

spiffxp commented Mar 24, 2021

Ah the joys of permissions...

$ gsutil rb gs://k8s-conform-capi-openstack/
Removing gs://k8s-conform-capi-openstack/...
NotEmptyException: 409 BucketNotEmpty (k8s-conform-capi-openstack)
$ gsutil rm -r gs://k8s-conform-capi-openstack/
Removing gs://k8s-conform-capi-openstack/README.md#1582738137715833...
AccessDeniedException: 403 Object 'k8s-conform-capi-openstack/README.md' is subject to bucket's retention policy and cannot be deleted, overwritten or archived until 2030-02-25T21:28:57.715612877-08:00
$ gsutil rm -rf gs://k8s-conform-capi-openstack/*
# ...
CommandException: 849 files/objects could not be removed.

I'll keep poking

@sbueringer
Copy link
Member Author

sbueringer commented Mar 24, 2021

Ah the joys of permissions...

$ gsutil rb gs://k8s-conform-capi-openstack/
Removing gs://k8s-conform-capi-openstack/...
NotEmptyException: 409 BucketNotEmpty (k8s-conform-capi-openstack)
$ gsutil rm -r gs://k8s-conform-capi-openstack/
Removing gs://k8s-conform-capi-openstack/README.md#1582738137715833...
AccessDeniedException: 403 Object 'k8s-conform-capi-openstack/README.md' is subject to bucket's retention policy and cannot be deleted, overwritten or archived until 2030-02-25T21:28:57.715612877-08:00
$ gsutil rm -rf gs://k8s-conform-capi-openstack/*
CommandException: 849 files/objects could not be removed.

I'll keep poking

Oh sorry :). Could also schedule a task for 2030 :)

Thank you!

@spiffxp
Copy link
Member

spiffxp commented Mar 24, 2021

$ gsutil lifecycle get gs://k8s-conform-capi-openstack
gs://k8s-conform-capi-openstack/ has no lifecycle configuration.
$ gsutil retention get gs://k8s-conform-capi-openstack
  Retention Policy (UNLOCKED):
    Duration: 10 Year(s)
    Effective Time: Wed, 05 Feb 2020 00:02:48 GMT
# $ gsutil iam get gs://k8s-conform-capi-openstack | json2yaml
bindings:
- members:
  - group:k8s-infra-artifact-admins@kubernetes.io
  - projectEditor:k8s-conform
  - projectOwner:k8s-conform
  role: roles/storage.legacyBucketOwner
- members:
  - projectViewer:k8s-conform
  role: roles/storage.legacyBucketReader
- members:
  - group:k8s-infra-conform-capi-openstack@kubernetes.io
  role: roles/storage.legacyBucketWriter
- members:
  - group:k8s-infra-artifact-admins@kubernetes.io
  - group:k8s-infra-conform-capi-openstack@kubernetes.io
  role: roles/storage.objectAdmin
- members:
  - serviceAccount:service-capi-openstack@k8s-conform.iam.gserviceaccount.com
  role: roles/storage.objectCreator
- members:
  - allUsers
  role: roles/storage.objectViewer
$ gsutil retention clear gs://k8s-conform-capi-openstack
Clearing Retention Policy on gs://k8s-conform-capi-openstack/...
$ gsutil retention get gs://k8s-conform-capi-openstack
gs://k8s-conform-capi-openstack/ has no Retention Policy.
$ gsutil -m rm -r gs://k8s-conform-capi-openstack
# ...
Operation completed over 838 objects.
Removing gs://k8s-conform-capi-openstack/...
$ gsutil rb -f gs://k8s-conform-capi-openstack
Removing gs://k8s-conform-capi-openstack/...

OK that should do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/audit Audit of project resources, audit followup issues, code in audit/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants