Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prow/cluster-api-provider-openstack: enable periodic and postsubmit conformance tests #21445

Merged
merged 2 commits into from
Mar 24, 2021
Merged

prow/cluster-api-provider-openstack: enable periodic and postsubmit conformance tests #21445

merged 2 commits into from
Mar 24, 2021

Conversation

sbueringer
Copy link
Member

This adds post-submit and periodic tests like the other CAPI providers have (but we test a bit less frequently (i.e. higher intervals).

The test results will then be available here: https://testgrid.k8s.io/sig-cluster-lifecycle-cluster-api-provider-openstack

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 19, 2021
@k8s-ci-robot k8s-ci-robot requested review from dims and Lion-Wei March 19, 2021 08:10
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 19, 2021
@sbueringer
Copy link
Member Author

/assign @jichenjc

Can you please take a look? Thx :)

@sbueringer sbueringer force-pushed the pr-enable-capo-postsubmits branch from dea7f5f to b3b6d62 Compare March 19, 2021 08:24
@k8s-ci-robot k8s-ci-robot added area/testgrid sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 19, 2021
@sbueringer sbueringer mentioned this pull request Mar 19, 2021
Merged
@sbueringer
Copy link
Member Author

sbueringer commented Mar 19, 2021 •
edited
Loading

/assign @fabriziopandini
(for the testgrid config change)

@fabriziopandini for context:

@sbueringer sbueringer mentioned this pull request Mar 19, 2021
Closed
6 tasks
@fabriziopandini
Copy link
Member

@sbueringer I don't have much context here, but given that testgrid config change as basically only cleanups, lgtm from my side

@sbueringer
Copy link
Member Author

@jichenjc can you please take a look? Thank you :)

@jichenjc
Copy link
Contributor

/lgtm

thanks~

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2021
@sbueringer
Copy link
Member Author

sbueringer commented Mar 24, 2021 •
edited
Loading

@jichenjc Thank you.

@fabriziopandini I think I need an approval from you (or somebody else in the config/testgrids/kubernetes/sig-cluster-lifecycle/OWNERS file) to merge this :)

@fabriziopandini
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2021
@fabriziopandini
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit 97252f2 into kubernetes:master Mar 24, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 24, 2021
@k8s-ci-robot
Copy link
Contributor

@sbueringer: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-provider-openstack-periodics.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-openstack/cluster-api-provider-openstack-periodics.yaml
  • key cluster-api-provider-openstack-postsubmits.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-openstack/cluster-api-provider-openstack-postsubmits.yaml
  • key cluster-api-provider-openstack-presubmits.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-openstack/cluster-api-provider-openstack-presubmits.yaml

In response to this:

This adds post-submit and periodic tests like the other CAPI providers have (but we test a bit less frequently (i.e. higher intervals).

The test results will then be available here: https://testgrid.k8s.io/sig-cluster-lifecycle-cluster-api-provider-openstack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer sbueringer deleted the pr-enable-capo-postsubmits branch March 24, 2021 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims Awaiting requested review from dims

@Lion-Wei Lion-Wei Awaiting requested review from Lion-Wei

Assignees

@fabriziopandini fabriziopandini

@jichenjc jichenjc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
4 participants
@sbueringer @fabriziopandini @jichenjc @k8s-ci-robot