Add k8s.io Nginx configuration. #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,5 @@ | |||
| canary process | |||
|
Mostly just nits. Can you add a redacted form of the SSL secret? Like https://github.com/kubernetes/k8s.io/blob/master/reviewable.k8s.io/secret-ssl.yaml (but without namespace specified) |
|
LGTM |
k8s-ci-robot
added a commit
that referenced
this pull request
Mar 5, 2020
legacy backfill attempt #2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
README.md sketches one way to do testing. If we don't want to require a separate cluster for testing, the Makefile should be modified to use namespaces.