Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move perfdash under /apps #2317

Merged
merged 4 commits into from
Jul 9, 2021
Merged

Move perfdash under /apps #2317

merged 4 commits into from
Jul 9, 2021

Conversation

jimdaga
Copy link

@jimdaga jimdaga commented Jul 9, 2021 •
edited
Loading

Resolves:

Changes:

  • Move perf-dash.k8s.io directory under the apps/perfdash path.
  • Add deploy.sh with some "custom" updates to apply the external yaml (based on existing README notes)
  • Update various README notes
  • Add app: label as needed

Notes:

  • Looking for feedback - should we drop the FQDN format (perf-dash.k8s.io) of the directory name to make it match the app: name (perfdash)?

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 9, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @jimdaga. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 9, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 9, 2021
@jimdaga jimdaga mentioned this pull request Jul 9, 2021
Closed
11 tasks
@spiffxp
Copy link
Member

spiffxp commented Jul 9, 2021

should we drop the FQDN format (perf-dash.k8s.io) of the directory name to make it match the app: name (perfdash)?

yes please, I did the same thing for node-perf-dash

@jimdaga jimdaga changed the title [WIP]Move perfdash under /apps Move perfdash under /apps Jul 9, 2021
@jimdaga jimdaga marked this pull request as ready for review July 9, 2021 21:32
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 9, 2021
spiffxp
spiffxp approved these changes Jul 9, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

apps/perfdash/deploy.sh
Comment on lines +53 to +54
kubectl --context="${context}" --namespace="${namespace}" apply -f "${perfdash_repo_url}/deployment.yaml"
kubectl --context="${context}" --namespace="${namespace}" apply -f "${perfdash_repo_url}/perfdash-service.yaml"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, TIL this is how it's always been for this app, so I won't blow your PR's scope. But these files should live here (I was thinking in the direction of a postsubmit job that could run the relevant deploy.sh if any app's files changed). Not a fan of deploy scripts that will deploy something different depending on the time of day they're run.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @mborsz @mm4tt @jprzychodzen

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jimdaga, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2021
@k8s-ci-robot k8s-ci-robot merged commit 930d08e into kubernetes:main Jul 9, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 9, 2021
@jimdaga jimdaga deleted the issue-2150/move-perfdash branch July 21, 2021 02:47
@jimdaga jimdaga mentioned this pull request Jul 30, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp approved these changes

@bartsmykla bartsmykla Awaiting requested review from bartsmykla

@thockin thockin Awaiting requested review from thockin

Assignees

@spiffxp spiffxp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
3 participants
@jimdaga @k8s-ci-robot @spiffxp