Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize apps running on aaa under /apps #2150

Closed
11 tasks done
spiffxp opened this issue Jun 7, 2021 · 10 comments
Closed
11 tasks done

Reorganize apps running on aaa under /apps #2150

spiffxp opened this issue Jun 7, 2021 · 10 comments
Assignees
Labels
area/infra Infrastructure management, infrastructure design, code in infra/ kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone

Comments

@spiffxp
Copy link
Member

spiffxp commented Jun 7, 2021

This will make it easier to setup a prowjob that auto-deploys these apps on postsubmit

We can also auto-label PRs against these apps and enforce ownership conventions:

  • group: k8s-infra-rbac-{app}@kubernetes.io
  • namespace on aaa: {app}
  • label on k8s resources: app: {app}
  • label on gcloud secrets: app: {app}
  • OWNERS: approvers: {app}-approvers
  • etc...

Going off of the list of namespaces in infra/gcp/namespaces/ensure-namespaces.sh and some manual inspection

/priority important-longterm
/kind cleanup
/wg k8s-infra
/area cluster-infra

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. wg/k8s-infra area/infra Infrastructure management, infrastructure design, code in infra/ labels Jun 7, 2021
@jimdaga
Copy link

jimdaga commented Jun 8, 2021

@spiffxp I could maybe give this a try;

Just to make sure I follow; you're looking to re-org this k8s.io repo so that the folders containing app code get moved under /apps - and the various labels, OWNER files, etc get updated to match the {app} name - correct?

Also; since you mentioned prow - I take it there is no existing deploy automation I'd have to consider, right?

@jimdaga
Copy link

jimdaga commented Jun 23, 2021

/assign @jimdaga

@jimdaga
Copy link

jimdaga commented Jul 2, 2021

Sorry things have been slow, I'm hoping to find some time soon to sit down and finish a bunch of PRs at once.

@spiffxp
Copy link
Member Author

spiffxp commented Jul 2, 2021

It's all good, I've been pretty slow myself. Updated description with what I think are the remaining apps, along with notes about which ones might be special cases. I am doing a few straightforward apps to get a feel for it, but will leave the rest open.

If I have time, I'll look at answering my questions on the tougher ones, but it's likely I won't have time, so could use help on those.

@spiffxp
Copy link
Member Author

spiffxp commented Jul 2, 2021

#2290 for kubernetes-external-secrets and node-perf-dash

@jimdaga
Copy link

jimdaga commented Jul 9, 2021

One more PR- but I have a question in the NOTES about directory names.
#2317

ameukam added a commit to ameukam/k8s.io that referenced this issue Jul 13, 2021
Part of kubernetes#2150

move prow(ghproxy) to apps
Ensure script `deploy.sh` is present
Ensure OWNERS is present.
Update k8s.io/README.md to refect changes

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
ameukam added a commit to ameukam/k8s.io that referenced this issue Jul 13, 2021
Part of kubernetes#2150

move prow(ghproxy) to apps
Ensure script `deploy.sh` is present
Ensure OWNERS is present.
Update k8s.io/README.md to refect changes

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@ameukam
Copy link
Member

ameukam commented Jul 16, 2021

kettle : the presence of this namespace is for kettle migration. We should remove it if we consider host kettle on a different GKE cluster during the migration.

@spiffxp
Copy link
Member Author

spiffxp commented Jul 22, 2021

I've opened #2386 to address fleshing out "what is an app" and generally anything else listed as a known issue in https://github.com/kubernetes/k8s.io/tree/main/apps#proposed-format

Thanks to all of this, I was able to move forward on auto-deploying apps #2151

@spiffxp
Copy link
Member Author

spiffxp commented Jul 22, 2021

/assign @spiffxp @ameukam
since we did a few of the apps, but mostly this was @jimdaga

/close
Calling this done!

@k8s-ci-robot
Copy link
Contributor

@spiffxp: Closing this issue.

In response to this:

/assign @spiffxp @ameukam
since we did a few of the apps, but mostly this was @jimdaga

/close
Calling this done!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infra Infrastructure management, infrastructure design, code in infra/ kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

No branches or pull requests

4 participants