-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apps: move prow #2330
apps: move prow #2330
Conversation
Part of kubernetes#2150 move prow(ghproxy) to apps Ensure script `deploy.sh` is present Ensure OWNERS is present. Update k8s.io/README.md to refect changes Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
/hold
Remove when ready to deploy
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ameukam, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
Figuring out what this is about
|
https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#label-selector-updates - right, updating a deployment's label selector isn't allowed in v1 since I couldn't tell that anything was using ghproxy in aaa, I deleted/recreated the deployment
|
Part of #2150
move prow(ghproxy) to apps
Ensure script
deploy.sh
is presentEnsure OWNERS is present.
Update k8s.io/README.md to refect changes
Signed-off-by: Arnaud Meukam ameukam@gmail.com