Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps: move prow #2330

Merged
merged 1 commit into from
Jul 13, 2021
Merged

apps: move prow #2330

merged 1 commit into from
Jul 13, 2021

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Jul 13, 2021

Part of #2150

move prow(ghproxy) to apps
Ensure script deploy.sh is present
Ensure OWNERS is present.
Update k8s.io/README.md to refect changes

Signed-off-by: Arnaud Meukam ameukam@gmail.com

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 13, 2021
@k8s-ci-robot k8s-ci-robot requested review from spiffxp and thockin July 13, 2021 06:34
@k8s-ci-robot k8s-ci-robot added wg/k8s-infra approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 13, 2021
Part of kubernetes#2150

move prow(ghproxy) to apps
Ensure script `deploy.sh` is present
Ensure OWNERS is present.
Update k8s.io/README.md to refect changes

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@ameukam
Copy link
Member Author

ameukam commented Jul 13, 2021

/assign @spiffxp
cc @jimdaga

Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/hold
Remove when ready to deploy

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jul 13, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spiffxp
Copy link
Member

spiffxp commented Jul 13, 2021

/hold cancel
I'll deploy

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 13, 2021
@k8s-ci-robot k8s-ci-robot merged commit 86afaac into kubernetes:main Jul 13, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 13, 2021
@spiffxp
Copy link
Member

spiffxp commented Jul 13, 2021

Figuring out what this is about

$ ./deploy.sh
persistentvolumeclaim/ghproxy configured
service/ghproxy configured
serviceaccount/ghproxy configured
externalsecret.kubernetes-client.io/k8s-infra-ci-robot-github-token configured
The Deployment "ghproxy" is invalid: spec.selector: Invalid value: v1.LabelSelector{MatchLabels:map[string]string{"component":"ghproxy"}, MatchExpressions:[]v1.LabelSelectorRequirement(nil)}: field is immutable

@spiffxp
Copy link
Member

spiffxp commented Jul 13, 2021

https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#label-selector-updates - right, updating a deployment's label selector isn't allowed in v1

since I couldn't tell that anything was using ghproxy in aaa, I deleted/recreated the deployment

spiffxp@cloudshell:~/k8s.io/apps/prow (spiffxp-gke-dev)$ k delete -f ghproxy_deployment.yaml
persistentvolumeclaim "ghproxy" deleted
deployment.apps "ghproxy" deleted
service "ghproxy" deleted
spiffxp@cloudshell:~/k8s.io/apps/prow (spiffxp-gke-dev)$ k create -f ghproxy_deployment.yaml
persistentvolumeclaim/ghproxy created
deployment.apps/ghproxy created
service/ghproxy created
spiffxp@cloudshell:~/k8s.io/apps/prow (spiffxp-gke-dev)$ ./deploy.sh
Warning: resource persistentvolumeclaims/ghproxy is missing the kubectl.kubernetes.io/last-applied-configuration annotation which is required by kubectl apply. kubectl apply should only be used on resources created declaratively by either kubectl create --save-config or kubectl apply. The missing annotation will be patched automatically.
persistentvolumeclaim/ghproxy configured
Warning: resource deployments/ghproxy is missing the kubectl.kubernetes.io/last-applied-configuration annotation which is required by kubectl apply. kubectl apply should only be used on resources created declaratively by either kubectl create --save-config or kubectl apply. The missing annotation will be patched automatically.
deployment.apps/ghproxy configured
Warning: resource services/ghproxy is missing the kubectl.kubernetes.io/last-applied-configuration annotation which is required by kubectl apply. kubectl apply should only be used on resources created declaratively by either kubectl create --save-config or kubectl apply. The missing annotation will be patched automatically.
service/ghproxy configured
serviceaccount/ghproxy unchanged
externalsecret.kubernetes-client.io/k8s-infra-ci-robot-github-token unchanged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants