Enable rolling updates for Hetzner #14034
Conversation
k8s-ci-robot
added
cncf-cla: yes
hakman
force-pushed
the
hetzner_server_groups
branch
from
8caf80d to
39b203c
Compare
| return fmt.Errorf("failed to stop server %q: %w", strconv.Itoa(id), err) | ||
| } | ||
|
|
||
| for i := 1; i <= 30; i++ { |
There was a problem hiding this comment.
Might want to log if we gave up on waiting for a clean shutdown here.
There was a problem hiding this comment.
Good point. Added on my TODO list.
| } | ||
|
|
||
| // findServerGroups finds all server groups belonging to the cluster | ||
| func findServerGroups(c *hetznerCloudImplementation, clusterName string) (map[string][]*hcloud.Server, error) { |
There was a problem hiding this comment.
Nit: if you're only calling this from GetCloudGroups, I think you could pass the instancegroups in and directly match the instancegroups, instead of constructing the magic string (?)
| Labels: server.Labels, | ||
| }) | ||
| if err != nil { | ||
| return err |
There was a problem hiding this comment.
Nit: when we get an error from calling the hetzner API (or any API), I don't know how good those errors are. It might be nice to fmt.Errorf("error setting needs-update label on %q: %w", serverName, err) for example.
|
This is nice! /approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Follow-up to #14018.
/cc @justinsb @olemarkus