Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait for load balancer to be ready for Hetzner #14057

Merged
merged 1 commit into from
Jul 29, 2022
Merged

Wait for load balancer to be ready for Hetzner #14057

merged 1 commit into from
Jul 29, 2022

Conversation

hakman
Copy link
Member

@hakman hakman commented Jul 29, 2022

FindAddresses() may run before the public addresses are allocated and the Kubernetes API certificate will not work.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 29, 2022
@k8s-ci-robot k8s-ci-robot requested a review from joshbranham July 29, 2022 07:25
@k8s-ci-robot k8s-ci-robot added the area/provider/hetzner Issues or PRs related to Hetzner provider label Jul 29, 2022
@hakman hakman force-pushed the hetzner_wait_lb_address branch from bd8f97e to 9829f6c Compare July 29, 2022 07:33
justinsb
justinsb reviewed Jul 29, 2022
View reviewed changes
upup/pkg/fi/cloudup/hetznertasks/loadbalancer.go Outdated
if err != nil {
if err != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks look an extra check of err != nil

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed this now, to make it easy to cherry-pick.

upup/pkg/fi/cloudup/hetznertasks/loadbalancer.go
}
}
_, errCh := actionClient.WatchProgress(ctx, action)
if err := <-errCh; err != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: we might want a helper here that calls WatchProgress, but also has a timer, so that we log e.g. every minute that we're waiting for something, rather than potentially silently waiting forever.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Thanks!

@justinsb
Copy link
Member

Two thoughts, but lgtm.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2022
@hakman hakman force-pushed the hetzner_wait_lb_address branch from 9829f6c to 271ce33 Compare July 29, 2022 11:52
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2022
@hakman hakman mentioned this pull request Jul 29, 2022
Closed
@hakman hakman requested a review from justinsb July 29, 2022 12:23
@rifelpet
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2022
@k8s-ci-robot k8s-ci-robot merged commit d7e9cfd into kubernetes:master Jul 29, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jul 29, 2022
@hakman hakman mentioned this pull request Jul 29, 2022
Merged
k8s-ci-robot added a commit that referenced this pull request Jul 29, 2022
@k8s-ci-robot
Merge pull request #14067 from hakman/automated-cherry-pick-of-#14034-#…
0bd14a8 
…14057-#14058-upstream-release-1.24

Automated cherry pick of #14034: Enable rolling updates for Hetzner
#14057: Wait for load balancer to be ready for Hetzner
#14058: Add multiple SSH keys support for Hetzner
@hakman hakman deleted the hetzner_wait_lb_address branch July 29, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshbranham joshbranham Awaiting requested review from joshbranham

@KashifSaadat KashifSaadat Awaiting requested review from KashifSaadat

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@justinsb justinsb

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/hetzner Issues or PRs related to Hetzner provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.
4 participants
@hakman @justinsb @k8s-ci-robot @rifelpet