Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: nodeup: try to workaround broken apt-get installations #16753

Closed
wants to merge 1 commit into from

Conversation

justinsb
Copy link
Member

The *bool logic wasn't doing what we needed because nil was treated as
"don't care".

The *bool logic wasn't doing what we needed because nil was treated as
"don't care".
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 15, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from justinsb. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justinsb justinsb changed the title package install: try to workaround broken apt-get installations WIP: nodeup: try to workaround broken apt-get installations Aug 15, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 15, 2024
@justinsb
Copy link
Member Author

I'm not sure this works either...

I0815 15:18:12.574355    7373 package.go:343] running command [apt-get install --yes --no-install-recommends libltdl7]
W0815 15:18:12.585018    7373 executor.go:141] error running task "Package/socat" (3m7s remaining to succeed): error installing package "socat": exit status 100: E: dpkg was interrupted, you must manually run 'dpkg --configure -a' to correct the problem.

@k8s-ci-robot
Copy link
Contributor

@justinsb: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-e2e-k8s-aws-calico 5f9e0b4 link true /test pull-kops-e2e-k8s-aws-calico
pull-kops-e2e-k8s-gce-ipalias 5f9e0b4 link true /test pull-kops-e2e-k8s-gce-ipalias
pull-kops-e2e-k8s-gce-cilium 5f9e0b4 link true /test pull-kops-e2e-k8s-gce-cilium

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hakman
Copy link
Member

hakman commented Sep 14, 2024

Issue fixed via #16755.
/close

@k8s-ci-robot
Copy link
Contributor

@hakman: Closed this PR.

In response to this:

Issue fixed via #16755.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants