-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nodeup: if apt-get tells us to run dpkg configure, run it #16755
nodeup: if apt-get tells us to run dpkg configure, run it #16755
Conversation
This is a fallback against some of nastier edge cases we can fall into otherwise.
This looks good. Probably #16751 should be combined with this to pass all the tests. |
/lgtm |
It doesn't look like this test is fully fixed in 1.31
Added the skiplist here, but I think there's something happening on GCE also which might still fail.... |
One step closer. |
/retest |
/test pull-kops-e2e-k8s-gce-cilium /test pull-kops-e2e-k8s-gce-ipalias |
The GCE failures seem to be new. The test was passing (not skipped) with 1.30.3, but the next invocation was with 1.31.0 and failed.
The retrieved vs expected sounds related to kubernetes/kubernetes#121018 (comment) Both jobs have identical --cloud-provider=external and --hostname-override flags though. |
/override pull-kops-e2e-k8s-aws-calico |
@justinsb: Overrode contexts on behalf of justinsb: pull-kops-e2e-k8s-aws-calico, pull-kops-e2e-k8s-gce-cilium, pull-kops-e2e-k8s-gce-ipalias In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm cancel |
/test all |
/override pull-kops-e2e-k8s-aws-calico |
@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-k8s-aws-calico, pull-kops-e2e-k8s-gce-cilium, pull-kops-e2e-k8s-gce-ipalias In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override pull-kops-e2e-k8s-aws-amazonvpc |
@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-k8s-aws-amazonvpc, pull-kops-kubernetes-e2e-ubuntu-gce-build In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override pull-kops-build |
@hakman: Overrode contexts on behalf of hakman: pull-kops-build In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/lgtm |
@justinsb I believe this is causing some regressions in GCE: https://testgrid.k8s.io/kops-network-plugins#kops-gce-cni-cilium-k8s-ci A node is failing to join the cluster, with:
|
This is a fallback against some of nastier edge cases we can fall into
otherwise.