Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodeup: if apt-get tells us to run dpkg configure, run it #16755

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

justinsb
Copy link
Member

This is a fallback against some of nastier edge cases we can fall into
otherwise.

This is a fallback against some of nastier edge cases we can fall into
otherwise.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 15, 2024
@hakman
Copy link
Member

hakman commented Aug 15, 2024

This looks good. Probably #16751 should be combined with this to pass all the tests.

@hakman
Copy link
Member

hakman commented Aug 15, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2024
It doesn't look like this test is fully fixed in 1.31
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2024
@justinsb
Copy link
Member Author

Added the skiplist here, but I think there's something happening on GCE also which might still fail....

@hakman
Copy link
Member

hakman commented Aug 15, 2024

Added the skiplist here, but I think there's something happening on GCE also which might still fail....

One step closer.

@hakman
Copy link
Member

hakman commented Aug 16, 2024

/retest

@justinsb
Copy link
Member Author

/test pull-kops-e2e-k8s-gce-cilium

/test pull-kops-e2e-k8s-gce-ipalias

@hakman hakman mentioned this pull request Aug 21, 2024
@rifelpet
Copy link
Member

rifelpet commented Aug 22, 2024

The GCE failures seem to be new. The test was passing (not skipped) with 1.30.3, but the next invocation was with 1.31.0 and failed.

  I0816 13:52:10.440180 50617 utils.go:352] encountered error during dial (received unexpected responses... 
  Attempt 0
  Command curl -g -q -s 'http://100.96.4.106:9080/dial?request=hostname&protocol=http&host=100.67.208.27&port=80&tries=1'
  retrieved map[nodes-us-east1-d-8ht1.c.k8s-infra-e2e-boskos-068.internal:{}]
  expected map[nodes-us-east1-d-1c9k:{} nodes-us-east1-d-8ht1:{} nodes-us-east1-d-gqhq:{} nodes-us-east1-d-zzq6:{}])
  [FAILED] in [It] - k8s.io/kubernetes/test/e2e/network/networking.go:479 @ 08/16/24 13:52:10.44 

The retrieved vs expected sounds related to kubernetes/kubernetes#121018 (comment)

Both jobs have identical --cloud-provider=external and --hostname-override flags though.

@justinsb
Copy link
Member Author

/override pull-kops-e2e-k8s-aws-calico
/override pull-kops-e2e-k8s-gce-cilium
/override pull-kops-e2e-k8s-gce-ipalias

@k8s-ci-robot
Copy link
Contributor

@justinsb: Overrode contexts on behalf of justinsb: pull-kops-e2e-k8s-aws-calico, pull-kops-e2e-k8s-gce-cilium, pull-kops-e2e-k8s-gce-ipalias

In response to this:

/override pull-kops-e2e-k8s-aws-calico
/override pull-kops-e2e-k8s-gce-cilium
/override pull-kops-e2e-k8s-gce-ipalias

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hakman
Copy link
Member

hakman commented Aug 23, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2024
@hakman
Copy link
Member

hakman commented Aug 23, 2024

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2024
@hakman
Copy link
Member

hakman commented Aug 23, 2024

/test all

@hakman
Copy link
Member

hakman commented Aug 23, 2024

/override pull-kops-e2e-k8s-aws-calico
/override pull-kops-e2e-k8s-gce-cilium
/override pull-kops-e2e-k8s-gce-ipalias

@k8s-ci-robot
Copy link
Contributor

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-k8s-aws-calico, pull-kops-e2e-k8s-gce-cilium, pull-kops-e2e-k8s-gce-ipalias

In response to this:

/override pull-kops-e2e-k8s-aws-calico
/override pull-kops-e2e-k8s-gce-cilium
/override pull-kops-e2e-k8s-gce-ipalias

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hakman
Copy link
Member

hakman commented Aug 23, 2024

/override pull-kops-e2e-k8s-aws-amazonvpc
/override pull-kops-kubernetes-e2e-ubuntu-gce-build

@k8s-ci-robot
Copy link
Contributor

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-k8s-aws-amazonvpc, pull-kops-kubernetes-e2e-ubuntu-gce-build

In response to this:

/override pull-kops-e2e-k8s-aws-amazonvpc
/override pull-kops-kubernetes-e2e-ubuntu-gce-build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hakman
Copy link
Member

hakman commented Aug 23, 2024

/override pull-kops-build

@k8s-ci-robot
Copy link
Contributor

@hakman: Overrode contexts on behalf of hakman: pull-kops-build

In response to this:

/override pull-kops-build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rifelpet
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2024
@k8s-ci-robot k8s-ci-robot merged commit f486a95 into kubernetes:master Aug 23, 2024
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Aug 23, 2024
@rifelpet
Copy link
Member

@justinsb I believe this is causing some regressions in GCE:

https://testgrid.k8s.io/kops-network-plugins#kops-gce-cni-cilium-k8s-ci

A node is failing to join the cluster, with:

W0828 12:39:10.230865    4618 executor.go:141] error running task "Package/cgroupfs-mount" (6m19s remaining to succeed): error installing package "cgroupfs-mount": exit status 100: Reading package lists...
Building dependency tree...
Reading state information...
cgroupfs-mount is already the newest version (1.4).
0 upgraded, 0 newly installed, 0 to remove and 103 not upgraded.
1 not fully installed or removed.
Need to get 0 B/316 kB of archives.
After this operation, 0 B of additional disk space will be used.
dpkg: error processing package chrony (--configure):
 package is in a very bad inconsistent state; you should
 reinstall it before attempting configuration
Errors were encountered while processing:
 chrony
needrestart is being skipped since dpkg has failed
E: Sub-process /usr/bin/dpkg returned an error code (1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants