[go1.20] .: bump govmomi to v0.30.6

[MadhavJivrajani]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Bumping govmomi to include an error check fix needed to work with go1.20. We made this fix in the CI, but were reliant on the text matching of error strings, which is why it didn't catch the actual issue. This

Fix in vmware/govmomi@b4eac19
PR to bump govmomi in cloud-provider-vsphere: kubernetes/cloud-provider-vsphere#738
Tracking issue: vmware/govmomi#3174

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

We probably would want to cherry-pick this to release branches that running on go1.20.

Does this PR introduce a user-facing change?

Fixes an issue where the vsphere cloud provider will not trust a certificate if:
* The issuer of the certificate is unknown (x509.UnknownAuthorityError)
* The requested name does not match the set of authorized names (x509.HostnameError)
* The error surfaced after attempting a connection contains one of the substrings: "certificate is not trusted" or "certificate signed by unknown authority"

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/assign @liggitt
/sig architecture

[k8s-ci-robot]

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dims]

@MadhavJivrajani when is this in-tree cloud provider going/scheduled to be removed?

[liggitt]

it would be helpful to add a release note describing the scenario where this cloud provider would not have been able to connect, or the error that would have surfaced

[liggitt]

looks like a new lint error:

ERROR: staging/src/k8s.io/legacy-cloud-providers/vsphere/credentialmanager.go:1: : # k8s.io/legacy-cloud-providers/vsphere [k8s.io/legacy-cloud-providers/vsphere.test]
ERROR: vsphere/vsphere_test.go:168:36: cannot use vpx.Setting (variable of type []"github.com/vmware/govmomi/vim25/types".BaseOptionValue) as *"github.com/vmware/govmomi/simulator".Registry value in argument to vapi.New (typecheck)
ERROR: //go:build !providerless

[MadhavJivrajani]

/retest

[MadhavJivrajani]

/retest

[MadhavJivrajani]

when is this in-tree cloud provider going/scheduled to be removed?

@dims - v1.30 at the earliest. In tree CPI is scheduled for 1.30, the legacy cloud provider itself I don't have an estimate for. Will need to follow up with SIG Cloud Provider.

cc @xing-yang fyi ^

[liggitt]

/lgtm
/approve

please open the picks (or replay the dependency update rather than an automated cherry-pick) to 1.25+

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: b2feac400d2750896fb0f9ae96e1552d300fc386

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, MadhavJivrajani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [liggitt]
• staging/src/k8s.io/legacy-cloud-providers/OWNERS [liggitt]
• vendor/OWNERS [liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[liggitt]

blocked on kubernetes/test-infra#30759 (like all PRs)

[pacoxu]

/retest
test infra failure is fixed.