Dependency update - Golang 1.20.0

[cpanato]

Tracking info

Link to any previous tracking issue: #2575

Golang mailing list announcement:

• go1.20rc1: https://groups.google.com/g/golang-announce/c/iqUo0Spdl9I/m/r6EJ6wR5BQAJ

SIG Release Slack thread:

Work items for Go1.20rc1

• kube-cross image update: golang: Build 1.20rc1 images #2816

  • image promotion: Image promotion for build-image v1.27.0-go1.20rc1-bullseye.0 k8s.io#4550

• go-runner image update: golang: Build 1.20rc1 images #2816

  • image promotion: Image promotion for build-image v2.3.1-go1.20rc1-bullseye.0 k8s.io#4551

• releng-ci image update: golang: Build 1.20rc1 images #2816

  • image promotion: not promoting this image

Work items for Go1.20rc2

announcement: https://groups.google.com/g/golang-announce/c/muM4ByrIMbM/m/U14tSKsbBAAJ

• kube-cross image update: golang: Build 1.20rc2 images #2846

  • image promotion: Image promotion for build-image v1.27.0-go1.20rc2-bullseye.0 k8s.io#4601

• go-runner image update: golang: Build 1.20rc2 images #2846

  • image promotion: Image promotion for build-image v2.3.1-go1.20rc2-bullseye.0 k8s.io#4602

• releng-ci image update: golang: Build 1.20rc2 images #2846

  • image promotion: not promoting this image

Work items for Go1.20rc3

announcement: https://groups.google.com/g/golang-announce/c/7SPnPbP2DTU/m/4tLT-Rg3AwAJ

• kube-cross image update: golang: Build 1.20rc3 images #2857

  • image promotion: Image promotion for build-image v1.27.0-go1.20rc3-bullseye.0 k8s.io#4639

• go-runner image update: golang: Build 1.20rc3 images #2857

  • image promotion: Image promotion for build-image v2.3.1-go1.20rc3-bullseye.0 k8s.io#4638

• releng-ci image update: golang: Build 1.20rc3 images #2857

  • image promotion: not promoting this image

Work items for Go1.20

announcement: https://groups.google.com/g/golang-announce/c/QMK8IQALDvA/m/JbovhzpOAAAJ

• kube-cross image update: golang: Build 1.20 images #2887

  • image promotion: Image promotion for build-image v1.27.0-go1.20-bullseye.0 k8s.io#4722

• go-runner image update: golang: Build 1.20 images #2887

  • image promotion: Image promotion for build-image v2.3.1-go1.20-bullseye.0 k8s.io#4723

• releng-ci image update: golang: Build 1.20 images #2887

  • image promotion: Image promotion for releng 1.20-bullseye-0 k8s.io#4724

After kube-cross image promotion

• kubernetes/kubernetes update (master): [go] Bump images, dependencies and versions to go 1.20 kubernetes#114502

  Ensure the following have been updated within the PR:

  • kube-cross image
  • go-runner image
  • publishing bot rules
  • test image

After kubernetes/kubernetes (master) has been updated

• k8s-cloud-builder image update: Bump k8s-cloud-builder and k8s-ci-builder to Go 1.20 #2895

• k8s-ci-builder image variants update: Bump k8s-cloud-builder and k8s-ci-builder to Go 1.20 #2895

• kubekins/krte image variants update: Update kubekins/krte to Go 1.20 test-infra#28651

Follow-up items

• Ensure the Golang issue template is updated with any new requirements

/assign
cc: @kubernetes/release-engineering

[liggitt]

Tracking PRs related to go1.20 that we would need to pick to 1.24+ release branches as part of an eventual update to go1.20:

• Fix TestJitterWithNegativeMaxFactor flaky test kubernetes#114078
  • 1.24: cherry pick of #114078: Fix TestJitterWithNegativeMaxFactor flaky test kubernetes#115003
  • 1.25: Automated cherry pick of #114078: Explicitly call rand.Seed() method kubernetes#115004
  • 1.26: Automated cherry pick of #114078: Explicitly call rand.Seed() method kubernetes#115005
• Fixes the issue #114145 kubernetes#114940
  • 1.24: Automated cherry pick of #114940: Fixes the issue #114145 kubernetes#115150
  • 1.25: Automated cherry pick of #114940: Fixes the issue #114145 kubernetes#115151
  • 1.26: Automated cherry pick of #114940: Fixes the issue #114145 kubernetes#115152
• bump honnef.co/go/tools to support go1.20 kubernetes#115129
  • 1.24: Automated cherry pick of #115129: bump honnef.co/go/tools to support go1.20 kubernetes#115172
  • 1.25: Automated cherry pick of #115129: bump honnef.co/go/tools to support go1.20 kubernetes#115170
  • 1.26: Automated cherry pick of #115129: bump honnef.co/go/tools to support go1.20 kubernetes#115169
• Avoid typechecking stdlib kubernetes#115382
  • 1.24: Automated cherry pick of #115382: Avoid typechecking stdlib kubernetes#115388
  • 1.25: Automated cherry pick of #115382: Avoid typechecking stdlib kubernetes#115387
  • 1.26: Automated cherry pick of #115382: Avoid typechecking stdlib kubernetes#115386
• *: Bump golangci-lint version and adapt to new linters kubernetes#115537
  • 1.24: [Cherrypick #115537][1.24]*: Bump golangci-lint version and adapt to new linters kubernetes#115607
  • 1.25: [Cherrypick #115537][1.25]*: Bump golangci-lint version and adapt to new linters kubernetes#115608
  • 1.26: [Cherrypick #115537][1.26]*: Bump golangci-lint version and adapt to new linters kubernetes#115611
• [Prepare for go1.20] *: Bump versions and fix tests kubernetes#114766
  • 1.24: [1.24] Cherry Pick of #114766: [Prepare for go1.20] *: Bump versions and fix tests kubernetes#115034
  • 1.25: [1.25] Cherry Pick of #114766: [Prepare for go1.20] *: Bump versions and fix tests kubernetes#115050
  • 1.26: [1.26] Cherry Pick of #114766: [Prepare for go1.20] *: Bump versions and fix tests kubernetes#115051
• Switch to assert.ErrorEquals from assert.Equal to check error equality kubernetes#112944
  • 1.24: Automated cherry pick of #112944: Switch to assert.ErrorEquals from assert.Equal to check error kubernetes#118208
  • 1.25: Automated cherry pick of #112944: Switch to assert.ErrorEquals from assert.Equal to check error kubernetes#118207
  • 1.26 fix merged into 1.26
• [go1.20] .: bump govmomi to v0.30.6 kubernetes#120736
  • 1.24: EOL
  • 1.25: [1.25][go1.20] .: bump govmomi to v0.30.6 kubernetes#120765
  • 1.26: [1.26][go1.20] .: bump govmomi to v0.30.6 kubernetes#120766
  • 1.27: [1.27][go1.20] .: bump govmomi to v0.30.6 kubernetes#120767
  • 1.28: [1.28][go1.20] .: bump govmomi to v0.30.6 kubernetes#120768

---

Tracking verification of conditions for bumping go1.20 on release branches:

• 2023-05-01: 3 months after go 1.20 release on 2023-02-01
• ~2023-05-11: 1 month after Kubernetes 1.27 release on go1.20 on 2023-04-11
• no regressions relative to go 1.19 known to impact Kubernetes
  • syscall.Faccessat and os.LookPath regression in Go 1.20 [1.20 backport] golang/go#58624 fixed - go1.20.2
  • cmd/link: relocation truncated to fit: R_ARM_CALL against `runtime.duffcopy' [1.20 backport] golang/go#58503 fixed, Disable unified build and static init optimization for tests kubernetes#115692 reverted
  • cmd/link/internal/arm: off-by-one error in trampoline phase call reachability calculation [1.20 backport] golang/go#59059 fixed - go1.20.3
• pass unit and integration tests with both go 1.20 and the original go version for the release branch
  • 1.24 - demonstrated in [1.24] test go1.20 kubernetes#118195
  • 1.25 - demonstrated in [1.25] test go1.20 kubernetes#118194
  • 1.26 - demonstrated in [1.26] test go1.20 kubernetes#118193
• any behavior changes in go 1.20 are mitigated to preserve existing behavior without requiring action by Kubernetes end-users
  • 1.24
  • 1.25
  • 1.26

---

Tracking the PR that actually bumps to go1.20:

• [go] Bump images, dependencies and versions to go 1.20 kubernetes#114502
  • 1.24: [release-1.24] releng/go: Update images, deps and version to go 1.20.5 kubernetes#119203
  • 1.25: [release-1.25] releng/go: Update images, deps and version to go 1.20.5 kubernetes#119202
  • 1.26: [release-1.26] releng/go: Update images, deps and version to go 1.20.5 kubernetes#119201

[xmudrii]

@cpanato @liggitt Are we good to close this issue? If not, what are remaining tasks?

[liggitt]

I'm still tracking taking 1.20 back to release-1.{24,25,26} in #2815 (comment)

[liggitt]

go 1.20 has been out for 3 months now, there are no open golang issues tracking backports of regression fixes to 1.20, and we're approaching 1 month after 1.27.0 release, so it's probably time to get the last prereq PRs merged to release-1.{24,25,26} to prep for bumping those branches to go1.20

[liggitt]

Ok, the 1.24-1.26 temporary PRs bumping just .go-version passed all tests and passed integration and unit tests on the original go versions for those branches.

I think we're ready for the real bumps with kube-cross updates, etc, then we can close out this issue 🎉

Can release management folks pick up the image/version bump PRs?

[cpanato]

I will take it

/assign

[liggitt]

did 1.24-1.26 ever get updated to go1.20?

[xmudrii]

As per https://github.com/kubernetes/release/blob/27700ffed3109700889f40b7bc8d690d90ea8dc5/images/k8s-cloud-builder/variants.yaml, no.

[liggitt]

any blockers? getting 1.24-1.26 onto go1.20 before go1.19 (and 1.24) hits EOL is important

[cpanato]

no blockers, if this is ready to be upgraded i will start working on that, will wait your green light @liggitt

[cpanato]

• go images: build go images for 1.26/1.25/1.24 release branches #3144 got 1.26/1.25/1.24

[cpanato]

closing branches are in 1.20 now 🎉

/close

[k8s-ci-robot]

@cpanato: Closing this issue.

In response to this:

closing branches are in 1.20 now 🎉

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.