Skip to content

add Replicaset -> ReplicationController conversion test #132890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Jul 15, 2025
Merged

add Replicaset -> ReplicationController conversion test #132890

k8s-ci-robot merged 1 commit into from
Jul 15, 2025
+100 −1

Conversation

@atiratree
Copy link
Member

@atiratree atiratree commented Jul 11, 2025 •
edited
Loading

to ensure we account for fields that are only present in ReplicaSet

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

and ensure we account for fields that are only supported by ReplicaSet

this was suggested by @liggitt in #128546 (comment)

Which issue(s) this PR is related to:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 11, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 11, 2025

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 11, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Apps Jul 11, 2025
@atiratree
add Replicaset -> ReplicationController conversion test
65e0cff 
and ensure we account for fields that are only supported by ReplicaSet
@atiratree atiratree force-pushed the replicaset-conversion branch from db47718 to 65e0cff Compare July 11, 2025 12:56
mimowo
mimowo reviewed Jul 14, 2025
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 14, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 14, 2025

LGTM label has been added.

Git tree hash: f1a9af7f8bfee75c869d0e383d269644ce62cdd9

@liggitt
Copy link
Member

liggitt commented Jul 15, 2025

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atiratree, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2025
@k8s-ci-robot k8s-ci-robot merged commit bdb7a01 into kubernetes:master Jul 15, 2025
13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jul 15, 2025
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in SIG Apps Jul 15, 2025
@wendy-ha18 wendy-ha18 mentioned this pull request Aug 26, 2025
Merged
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 27, 2025
@atiratree atiratree mentioned this pull request Nov 17, 2025
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saad-ali saad-ali Awaiting requested review from saad-ali

@tallclair tallclair Awaiting requested review from tallclair

1 more reviewer

@mimowo mimowo mimowo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@liggitt liggitt

@mimowo mimowo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

SIG Apps
Archived in project

Milestone

v1.34

Development

Successfully merging this pull request may close these issues.

4 participants

@atiratree @k8s-ci-robot @liggitt @mimowo