-
Notifications
You must be signed in to change notification settings - Fork 432
Update release notes draft to version v1.34.0-rc.2 #2845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update release notes draft to version v1.34.0-rc.2 #2845
Conversation
Signed-off-by: Rashan Smith <smith.rashan@gmail.com>
| @@ -0,0 +1,4 @@ | |||
| pr: 132890 | |||
| releasenote: | |||
| text: 'NONE.' | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we reach out to the author of PR kubernetes/kubernetes#132890 to make sure the PR didn't need release note or the author forgot to include it?
Cause if the PR doesn't need release note, this file can be removed out of maps and release-notes-draft.json/.md file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reached out. Do we have a limit on when to expect to hear back vs. moving forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally when we have time, I would properly suggest to wait for contributor to get back 1 or 2 days cause sometime they will busy with their own schedule. However, considering these factors:
- timing of final release cut today.
- the purpose of PR 132890 was for improving internal test coverage (added a conversion test to check that when a ReplicaSet object is converted to a ReplicationController) only, not end-user visible change as Does my pull request need a release note guidance here.
- this PR is kind cleanup
I would suggest we remove this map.
cc @Vyom-Yadav for awareness.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's clean this up here first and later we can get this corrected in the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Author confirmed release note is not needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rashansmith , so it's good to remove this map
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed that note
|
🔴 It seems like the According to this discussion from Release Announcement: kubernetes/website#51877 (comment). (view screenshot).
The PR #131837 should reserve the However the newest release-note-draft.md/json only include a part of it: Could you please also help to include the |
Signed-off-by: Vyom Yadav <jackhammervyom@gmail.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rashansmith, Vyom-Yadav The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |

What type of PR is this?
/kind documentation
What this PR does / why we need it:
This PR updates the Release Notes Draft to k/k v1.34.0-rc.2
Which issue(s) this PR fixes:
Special notes for your reviewer:
This is an automated PR generated from
krel The Kubernetes Release Toolbox