Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build using go1.9.3 #59012

Merged
merged 2 commits into from
Jan 30, 2018
Merged

Conversation

ixdy
Copy link
Member

@ixdy ixdy commented Jan 30, 2018

What this PR does / why we need it: more minor bugfixes, which I guess we probably want. https://github.com/golang/go/issues?q=milestone%3AGo1.9.3

Special notes for your reviewer: I haven't built/pushed the crossbuild image yet, but will do so if we think this is a good idea. I don't have plans to rebuild the test images.

Release note:

Build using go1.9.3.

Who are good people to review this?
/assign @cblecker @luxas
(for lack of better ideas)

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 30, 2018
@cblecker
Copy link
Member

@ixdy Looks good to me (pending image push)

@cblecker
Copy link
Member

(and this should be picked back to 1.9)

@ixdy
Copy link
Member Author

ixdy commented Jan 30, 2018

crossbuild image pushed.

/retest

@cblecker
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, ixdy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 783790a into kubernetes:master Jan 30, 2018
@ixdy
Copy link
Member Author

ixdy commented Feb 7, 2018

cherrypick PR: #59498

@cblecker
Copy link
Member

cblecker commented Feb 7, 2018

@ixdy go1.9.4 is coming out today with a security fix. we should probably pause for that before cherry pick.

@ixdy
Copy link
Member Author

ixdy commented Feb 7, 2018

good call.

k8s-github-robot pushed a commit that referenced this pull request Mar 3, 2018
…pstream-release-1.9

Automatic merge from submit-queue.

Automated cherry pick of #59012

Cherry pick of #59012 on release-1.9.

#59012: Update to go1.9.3
@ixdy ixdy deleted the update-to-go1.9.3 branch May 15, 2018 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants