Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the "none" driver does not use correct container runtime #3295

Closed
afbjorklund opened this issue Nov 4, 2018 · 3 comments
Closed

the "none" driver does not use correct container runtime #3295

afbjorklund opened this issue Nov 4, 2018 · 3 comments
Assignees
@afbjorklund
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@afbjorklund
Copy link
Collaborator

BUG REPORT

Currently the "none" driver is hardcoded to look for docker: cb8d3c0

It should look at the --container-runtime, and adjust accordingly...

(From #3153)
@afbjorklund afbjorklund changed the title the "none" driver always requires docker the "none" driver does not use correct container runtime Nov 4, 2018
@afbjorklund afbjorklund mentioned this issue Nov 4, 2018
Merged
afbjorklund added a commit to afbjorklund/minikube that referenced this issue Nov 6, 2018
@afbjorklund
Only require docker for the docker runtime
0fcdbd2 
Closes kubernetes#3295
@afbjorklund afbjorklund mentioned this issue Nov 6, 2018
Merged
afbjorklund added a commit to afbjorklund/minikube that referenced this issue Nov 6, 2018
@afbjorklund
Only require docker for the docker runtime
e64793f 
Closes kubernetes#3295
@tstromberg tstromberg added the kind/bug Categorizes issue or PR as related to a bug. label Nov 6, 2018
afbjorklund added a commit to afbjorklund/minikube that referenced this issue Nov 7, 2018
@afbjorklund
Only require docker for the docker runtime
558fc9c 
Closes kubernetes#3295
@balopat balopat closed this as completed Nov 13, 2018
@tstromberg
Copy link
Contributor

@afbjorklund appears to be working on this.

@balopat balopat reopened this Nov 13, 2018
balopat pushed a commit that referenced this issue Nov 27, 2018
@afbjorklund @balopat
Only require docker for the docker runtime (#3303)
57f4d92 
Closes #3295
@afbjorklund afbjorklund mentioned this issue Jan 23, 2019
Closed
6 tasks
@jayunit100
Copy link
Member

any updates here ?

@jayunit100 jayunit100 mentioned this issue Mar 8, 2019
Closed
@afbjorklund
Copy link
Collaborator Author

As long as you use --container-runtime=cri-o, it should work now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afbjorklund afbjorklund

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tstromberg @balopat @jayunit100 @afbjorklund