Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #3261

Merged
merged 1 commit into from
Nov 6, 2018
Merged

Update README.md #3261

merged 1 commit into from
Nov 6, 2018

Conversation

jayunit100
Copy link
Member

Make it clear that for none, you must be running standard docker.

Make it clear that for none, you must be running standard docker.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 18, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jayunit100
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: dlorenc

If they are not already assigned, you can assign the PR to them by writing /assign @dlorenc in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@afbjorklund
Copy link
Collaborator

It would be better to fix this bug, than to document it...

minikube should respect the --container-runtime

@@ -124,7 +124,8 @@ We also released a Debian package and Windows installer on our [releases page](h
## Quickstart

Here's a brief demo of Minikube usage.
If you want to change the VM driver add the appropriate `--vm-driver=xxx` flag to `minikube start`. Minikube supports
- If you want to change the container runtime, network details, consult notes from your container runtime provider.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK whatever may be the container runtime minikube should use it.

@afbjorklund
Copy link
Collaborator

Added #3295

@tstromberg tstromberg merged commit b410b6d into kubernetes:master Nov 6, 2018
@afbjorklund
Copy link
Collaborator

Added #3303 to do it properly instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants