Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Restore "containerd: upgrade io.containerd.runtime.v1.linux to io.containerd.runc.v2 (suppot cgroup v2)"" #11617

Merged
merged 1 commit into from
Jun 10, 2021

Conversation

ilya-zuyev
Copy link
Contributor

Reverts #11561

…o io.containerd.runc.v2 (suppot cgroup v2)""
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 9, 2021
@k8s-ci-robot k8s-ci-robot requested review from prasadkatti and RA489 June 9, 2021 22:26
@ilya-zuyev
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 9, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11617) |
+----------------+----------+---------------------+
| minikube start | 47.7s    | 47.3s               |
| enable ingress | 37.8s    | 38.8s               |
+----------------+----------+---------------------+

Times for minikube ingress: 36.1s 34.2s 42.3s 41.8s 34.7s
Times for minikube (PR 11617) ingress: 36.7s 43.3s 36.3s 42.7s 35.1s

Times for minikube start: 49.5s 48.7s 45.8s 47.1s 47.5s
Times for minikube (PR 11617) start: 46.0s 47.7s 46.1s 45.7s 50.9s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11617) |
+----------------+----------+---------------------+
| minikube start | 22.0s    | 22.0s               |
| enable ingress | 36.3s    | 33.6s               |
+----------------+----------+---------------------+

Times for minikube start: 23.7s 20.8s 21.3s 22.3s 21.6s
Times for minikube (PR 11617) start: 21.2s 22.0s 23.0s 22.0s 21.7s

Times for minikube ingress: 33.5s 35.5s 38.4s 41.0s 32.9s
Times for minikube (PR 11617) ingress: 32.4s 35.0s 33.5s 32.5s 34.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11617) |
+----------------+----------+---------------------+
| minikube start | 41.6s    | 45.5s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 31.6s 43.1s 43.3s 47.2s 43.0s
Times for minikube (PR 11617) start: 46.7s 47.5s 43.2s 47.2s 43.0s

@ilya-zuyev
Copy link
Contributor Author

/ok-to-test

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11617) |
+----------------+----------+---------------------+
| minikube start | 47.8s    | 47.4s               |
| enable ingress | 34.5s    | 34.8s               |
+----------------+----------+---------------------+

Times for minikube start: 48.4s 47.2s 47.0s 46.5s 49.6s
Times for minikube (PR 11617) start: 47.9s 46.8s 46.7s 47.7s 48.2s

Times for minikube ingress: 34.8s 33.7s 34.8s 35.2s 34.2s
Times for minikube (PR 11617) ingress: 34.8s 34.7s 34.7s 35.8s 34.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11617) |
+----------------+----------+---------------------+
| minikube start | 22.4s    | 21.8s               |
| enable ingress | 28.6s    | 29.5s               |
+----------------+----------+---------------------+

Times for minikube start: 22.9s 22.2s 21.8s 22.6s 22.5s
Times for minikube (PR 11617) start: 21.9s 22.0s 22.2s 21.7s 21.0s

Times for minikube ingress: 27.5s 29.5s 28.5s 28.5s 29.0s
Times for minikube (PR 11617) ingress: 29.0s 27.5s 28.0s 31.0s 32.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11617) |
+----------------+----------+---------------------+
| minikube start | 41.7s    | 45.6s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 31.3s 43.7s 43.2s 47.0s 43.2s
Times for minikube (PR 11617) start: 47.8s 44.3s 43.3s 48.9s 43.7s

@sharifelgamal sharifelgamal merged commit 96863f9 into master Jun 10, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ilya-zuyev, sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ilya-zuyev,sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh medyagh deleted the revert-11561-ilyaz/fix_ctrd branch January 20, 2022 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants