Restore "containerd: upgrade io.containerd.runtime.v1.linux to io.containerd.runc.v2 (suppot cgroup v2)" #11561

ilya-zuyev · 2021-06-02T00:32:43Z

This PR returns changes in containerd config initially merged in #11325 and then reverted in #11509

Comparing to the initial PR this one changes two things:

no_pivot_root option removed: [plugins.cri.containerd.default_runtime.options] NoPivotRoot = true
cgroups configuration changed according to how to configure systemd cgroup with 1.3.X containerd/containerd#4203 (comment)

k8s-ci-robot · 2021-06-02T00:32:44Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

ilya-zuyev · 2021-06-02T00:32:56Z

/ok-to-test

minikube-pr-bot · 2021-06-02T01:20:20Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11561) |
+----------------+----------+---------------------+
| minikube start | 47.7s    | 47.0s               |
| enable ingress | 40.2s    | 38.0s               |
+----------------+----------+---------------------+

Times for minikube start: 48.9s 48.4s 47.1s 47.6s 46.5s
Times for minikube (PR 11561) start: 47.5s 46.2s 47.3s 47.4s 46.6s

Times for minikube ingress: 36.2s 36.3s 44.3s 42.2s 42.2s
Times for minikube (PR 11561) ingress: 41.2s 34.3s 37.2s 41.8s 35.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11561) |
+----------------+----------+---------------------+
| minikube start | 22.1s    | 21.5s               |
| enable ingress | 34.2s    | 34.2s               |
+----------------+----------+---------------------+

Times for minikube start: 22.5s 21.8s 22.5s 21.4s 22.2s
Times for minikube (PR 11561) start: 21.4s 21.1s 21.3s 22.4s 21.4s

Times for minikube ingress: 34.5s 33.5s 32.5s 36.5s 34.0s
Times for minikube (PR 11561) ingress: 33.5s 35.9s 35.5s 31.5s 34.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11561) |
+----------------+----------+---------------------+
| minikube start | 41.6s    | 44.1s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 31.2s 47.0s 43.1s 42.9s 43.9s
Times for minikube (PR 11561) start: 43.1s 43.7s 47.2s 43.6s 43.0s

ilya-zuyev · 2021-06-02T05:25:26Z

the simple way to reproduce is:

ilyaz@skeletron --- z/minikube ‹ilyaz/fix_ctrd* ?› » m start -p foo --memory=2048 --force-systemd  --container-runtime=containerd                                                                                                                       130 ↵
* [foo] minikube v1.20.0 on Ubuntu 21.04
* Using the docker driver based on existing profile
! Your cgroup does not allow setting memory.
  - More information: https://docs.docker.com/engine/install/linux-postinstall/#your-kernel-does-not-support-cgroup-swap-limit-capabilities
! Your cgroup does not allow setting memory.
  - More information: https://docs.docker.com/engine/install/linux-postinstall/#your-kernel-does-not-support-cgroup-swap-limit-capabilities
* Starting control plane node foo in cluster foo
* Pulling base image ...
* Updating the running docker "foo" container ...

X Docker is nearly out of disk space, which may cause deployments to fail! (91% of capacity)
* Suggestion: 

    Try one or more of the following to free up space on the device:
    
    1. Run "docker system prune" to remove unused Docker data (optionally with "-a")
    2. Increase the storage allocated to Docker for Desktop by clicking on:
    Docker icon > Preferences > Resources > Disk Image Size
    3. Run "minikube ssh -- docker system prune" if using the Docker container runtime
* Related issue: https://github.com/kubernetes/minikube/issues/9024



X Exiting due to RUNTIME_ENABLE: Temporary Error: sudo crictl version: Process exited with status 1
stdout:

stderr:
time="2021-06-02T05:21:59Z" level=fatal msg="getting the runtime version: rpc error: code = Unimplemented desc = unknown service runtime.v1alpha2.RuntimeService"

* 
╭──────────────────────────────────────────────────────────────────────────────╮
│                                                                              │
│    * If the above advice does not help, please let us know:                  │
│      https://github.com/kubernetes/minikube/issues/new/choose                │
│                                                                              │
│    * Please attach the following file to the GitHub issue:                   │
│    * - /tmp/minikube_start_51a416570cf835863479e595b3e3ebe4602c90e1_0.log    │
│                                                                              │
╰──────────────────────────────────────────────────────────────────────────────╯

ilya-zuyev · 2021-06-02T05:35:09Z

seems related to containerd/containerd#4574

minikube-pr-bot · 2021-06-02T06:39:21Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11561) |
+----------------+----------+---------------------+
| minikube start | 47.8s    | 47.4s               |
| enable ingress | 39.8s    | 38.4s               |
+----------------+----------+---------------------+

Times for minikube start: 50.3s 47.0s 46.3s 48.6s 46.9s
Times for minikube (PR 11561) start: 50.1s 47.7s 46.2s 46.8s 46.2s

Times for minikube (PR 11561) ingress: 41.8s 35.7s 42.7s 36.7s 35.2s
Times for minikube ingress: 38.7s 37.7s 42.2s 42.8s 37.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11561) |
+----------------+----------+---------------------+
| minikube start | 22.1s    | 21.4s               |
| enable ingress | 34.1s    | 35.8s               |
+----------------+----------+---------------------+

Times for minikube ingress: 32.5s 33.0s 33.5s 37.5s 34.0s
Times for minikube (PR 11561) ingress: 39.0s 37.9s 32.5s 36.5s 33.0s

Times for minikube start: 23.7s 22.4s 21.9s 21.7s 20.5s
Times for minikube (PR 11561) start: 21.0s 21.9s 20.9s 21.9s 21.2s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11561) |
+----------------+----------+---------------------+
| minikube start | 41.3s    | 44.9s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 32.8s 43.0s 43.6s 43.8s 43.5s
Times for minikube (PR 11561) start: 46.9s 43.5s 43.6s 43.6s 46.9s

minikube-pr-bot · 2021-06-03T20:05:16Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11561) |
+----------------+----------+---------------------+
| minikube start | 50.4s    | 48.3s               |
| enable ingress | 34.7s    | 36.2s               |
+----------------+----------+---------------------+

Times for minikube start: 53.6s 47.7s 54.2s 48.3s 48.5s
Times for minikube (PR 11561) start: 51.8s 47.3s 46.9s 47.4s 47.9s

Times for minikube ingress: 36.1s 34.3s 34.3s 35.2s 33.7s
Times for minikube (PR 11561) ingress: 42.3s 36.2s 34.7s 34.2s 33.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11561) |
+----------------+----------+---------------------+
| minikube start | 21.6s    | 20.8s               |
| enable ingress | 30.2s    | 30.5s               |
+----------------+----------+---------------------+

Times for minikube start: 22.7s 21.0s 21.3s 21.1s 21.9s
Times for minikube (PR 11561) start: 20.4s 20.4s 21.1s 21.1s 21.2s

Times for minikube ingress: 29.5s 29.0s 33.5s 30.5s 28.5s
Times for minikube (PR 11561) ingress: 31.5s 28.5s 28.5s 33.0s 31.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11561) |
+----------------+----------+---------------------+
| minikube start | 42.4s    | 43.9s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 32.7s 46.6s 43.0s 47.1s 42.6s
Times for minikube (PR 11561) start: 42.8s 43.1s 42.9s 43.7s 47.0s

minikube-pr-bot · 2021-06-04T00:31:59Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11561) |
+----------------+----------+---------------------+
| minikube start | 50.9s    | 50.2s               |
| enable ingress | 37.8s    | 36.0s               |
+----------------+----------+---------------------+

Times for minikube start: 54.0s 50.0s 49.5s 50.0s 51.0s
Times for minikube (PR 11561) start: 47.4s 48.4s 48.9s 51.6s 54.6s

Times for minikube ingress: 38.4s 41.7s 33.8s 41.3s 33.8s
Times for minikube (PR 11561) ingress: 42.3s 33.8s 34.8s 34.3s 34.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11561) |
+----------------+----------+---------------------+
| minikube start | 22.3s    | 22.6s               |
| enable ingress | 33.3s    | 32.2s               |
+----------------+----------+---------------------+

Times for minikube (PR 11561) start: 23.1s 22.8s 22.9s 22.7s 21.4s
Times for minikube start: 22.3s 22.6s 22.3s 22.4s 22.1s

Times for minikube ingress: 32.0s 33.0s 35.0s 33.0s 33.5s
Times for minikube (PR 11561) ingress: 31.0s 33.0s 31.5s 32.0s 33.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11561) |
+----------------+----------+---------------------+
| minikube start | 45.6s    | 43.5s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 48.4s 48.3s 43.8s 43.6s 43.8s
Times for minikube (PR 11561) start: 42.0s 44.4s 43.8s 43.9s 43.3s

minikube-pr-bot · 2021-06-04T18:10:36Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11561) |
+----------------+----------+---------------------+
| minikube start | 47.4s    | 49.0s               |
| enable ingress | 34.9s    | 35.9s               |
+----------------+----------+---------------------+

Times for minikube ingress: 32.7s 35.3s 37.2s 35.2s 34.2s
Times for minikube (PR 11561) ingress: 34.2s 34.8s 33.8s 34.8s 41.8s

Times for minikube start: 49.3s 47.0s 45.5s 48.4s 46.6s
Times for minikube (PR 11561) start: 49.1s 50.0s 48.8s 50.8s 46.5s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11561) |
+----------------+----------+---------------------+
| minikube start | 21.6s    | 21.3s               |
| enable ingress | 30.9s    | 30.6s               |
+----------------+----------+---------------------+

Times for minikube start: 22.7s 21.7s 20.9s 21.5s 21.3s
Times for minikube (PR 11561) start: 20.3s 21.7s 20.8s 21.2s 22.6s

Times for minikube (PR 11561) ingress: 32.5s 31.0s 29.5s 29.0s 31.0s
Times for minikube ingress: 33.0s 30.0s 28.5s 32.5s 30.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11561) |
+----------------+----------+---------------------+
| minikube start | 42.2s    | 44.8s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 32.8s 43.9s 43.0s 48.5s 42.9s
Times for minikube (PR 11561) start: 42.8s 43.2s 47.5s 43.3s 47.2s

minikube-pr-bot · 2021-06-07T23:34:17Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11561) |
+----------------+----------+---------------------+
| minikube start | 48.7s    | 48.4s               |
| enable ingress | 37.2s    | 39.7s               |
+----------------+----------+---------------------+

Times for minikube start: 50.9s 50.7s 47.0s 46.3s 48.6s
Times for minikube (PR 11561) start: 47.7s 47.3s 51.4s 49.9s 45.9s

Times for minikube ingress: 41.7s 34.2s 38.3s 35.8s 35.8s
Times for minikube (PR 11561) ingress: 43.3s 34.8s 42.2s 42.4s 35.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11561) |
+----------------+----------+---------------------+
| minikube start | 22.0s    | 22.3s               |
| enable ingress | 33.1s    | 34.8s               |
+----------------+----------+---------------------+

Times for minikube ingress: 31.5s 30.0s 36.5s 34.0s 33.5s
Times for minikube (PR 11561) ingress: 31.5s 33.5s 36.5s 37.5s 35.0s

Times for minikube start: 23.0s 21.2s 21.8s 22.5s 21.7s
Times for minikube (PR 11561) start: 22.7s 21.4s 22.2s 22.5s 22.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11561) |
+----------------+----------+---------------------+
| minikube start | 42.5s    | 41.7s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 33.6s 43.4s 44.2s 43.2s 47.9s
Times for minikube (PR 11561) start: 30.1s 43.6s 43.9s 47.6s 43.3s

k8s-ci-robot · 2021-06-08T18:15:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ilya-zuyev, sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [ilya-zuyev,sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Restore config

0096815

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 2, 2021

k8s-ci-robot requested review from blueelvis and sharifelgamal June 2, 2021 00:32

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2021

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Jun 2, 2021

ilya-zuyev mentioned this pull request Jun 2, 2021

[wip] Restore "containerd: upgrade io.containerd.runtime.v1.linux to io.containerd.runc.v2 (suppot cgroup v2)" #11556

Closed

ilya-zuyev added 2 commits June 1, 2021 22:50

Fix cgroups setting

1fdd935

Fix cgroups setting

1cd44ce

Fix integration test

4bb1752

Trigger build

fa2ba4a

ilya-zuyev added 2 commits June 4, 2021 10:27

Fix logs

13e02b1

Merge branch 'master' into ilyaz/fix_ctrd

6ed3705

ilya-zuyev marked this pull request as ready for review June 7, 2021 17:48

ilya-zuyev changed the title ~~[wip] Restore "containerd: upgrade io.containerd.runtime.v1.linux to io.containerd.runc.v2 (suppot cgroup v2)"~~ Restore "containerd: upgrade io.containerd.runtime.v1.linux to io.containerd.runc.v2 (suppot cgroup v2)" Jun 7, 2021

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 7, 2021

ilya-zuyev added 2 commits June 7, 2021 15:44

Merge branch 'master' into ilyaz/fix_ctrd

89b8787

Merge branch 'master' into ilyaz/fix_ctrd

e7bcd5c

sharifelgamal approved these changes Jun 8, 2021

View reviewed changes

ilya-zuyev merged commit 471207b into kubernetes:master Jun 8, 2021

ilya-zuyev mentioned this pull request Jun 9, 2021

Revert "Restore "containerd: upgrade io.containerd.runtime.v1.linux to io.containerd.runc.v2 (suppot cgroup v2)"" #11617

Merged

ilya-zuyev mentioned this pull request Jun 25, 2021

Restore "containerd: upgrade io.containerd.runtime.v1.linux to io.containerd.runc.v2 (suppot cgroup v2)" #2 #11632

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Restore "containerd: upgrade io.containerd.runtime.v1.linux to io.containerd.runc.v2 (suppot cgroup v2)" #11561

Restore "containerd: upgrade io.containerd.runtime.v1.linux to io.containerd.runc.v2 (suppot cgroup v2)" #11561

ilya-zuyev commented Jun 2, 2021 •

edited

Loading

k8s-ci-robot commented Jun 2, 2021

ilya-zuyev commented Jun 2, 2021

minikube-pr-bot commented Jun 2, 2021

ilya-zuyev commented Jun 2, 2021

ilya-zuyev commented Jun 2, 2021

minikube-pr-bot commented Jun 2, 2021

minikube-pr-bot commented Jun 3, 2021

minikube-pr-bot commented Jun 4, 2021

minikube-pr-bot commented Jun 4, 2021

minikube-pr-bot commented Jun 7, 2021

k8s-ci-robot commented Jun 8, 2021

Restore "containerd: upgrade io.containerd.runtime.v1.linux to io.containerd.runc.v2 (suppot cgroup v2)" #11561

Restore "containerd: upgrade io.containerd.runtime.v1.linux to io.containerd.runc.v2 (suppot cgroup v2)" #11561

Conversation

ilya-zuyev commented Jun 2, 2021 • edited Loading

k8s-ci-robot commented Jun 2, 2021

ilya-zuyev commented Jun 2, 2021

minikube-pr-bot commented Jun 2, 2021

ilya-zuyev commented Jun 2, 2021

ilya-zuyev commented Jun 2, 2021

minikube-pr-bot commented Jun 2, 2021

minikube-pr-bot commented Jun 3, 2021

minikube-pr-bot commented Jun 4, 2021

minikube-pr-bot commented Jun 4, 2021

minikube-pr-bot commented Jun 7, 2021

k8s-ci-robot commented Jun 8, 2021

ilya-zuyev commented Jun 2, 2021 •

edited

Loading