Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "containerd: upgrade io.containerd.runtime.v1.linux to io.containerd.runc.v2 (suppot cgroup v2)" #11509

Merged
merged 1 commit into from
May 26, 2021

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented May 26, 2021

Reverts #11325

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 26, 2021
@medyagh
Copy link
Member Author

medyagh commented May 26, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 26, 2021
@k8s-ci-robot k8s-ci-robot requested review from ilya-zuyev and prezha May 26, 2021 02:41
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2021
@AkihiroSuda
Copy link
Member

Could you explain the regression?

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11509) |
+----------------+----------+---------------------+
| minikube start | 47.6s    | 47.3s               |
| enable ingress | 35.1s    | 34.0s               |
+----------------+----------+---------------------+

Times for minikube start: 47.2s 47.2s 48.2s 46.8s 48.4s
Times for minikube (PR 11509) start: 46.9s 47.9s 47.4s 47.8s 46.5s

Times for minikube ingress: 34.8s 35.2s 34.8s 36.7s 33.9s
Times for minikube (PR 11509) ingress: 36.3s 33.8s 32.8s 33.8s 33.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11509) |
+----------------+----------+---------------------+
| minikube start | 21.6s    | 21.4s               |
| enable ingress | 32.1s    | 33.5s               |
+----------------+----------+---------------------+

Times for minikube start: 22.9s 21.4s 22.2s 20.7s 20.9s
Times for minikube (PR 11509) start: 21.2s 21.2s 21.3s 21.1s 22.2s

Times for minikube ingress: 29.0s 31.5s 31.5s 37.5s 31.0s
Times for minikube (PR 11509) ingress: 29.5s 33.0s 31.5s 37.0s 36.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11509) |
+----------------+----------+---------------------+
| minikube start | 43.0s    | 45.6s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 31.2s 46.6s 47.0s 47.1s 43.1s
Times for minikube (PR 11509) start: 46.8s 43.1s 47.6s 47.1s 43.2s

@medyagh
Copy link
Member Author

medyagh commented May 26, 2021

Could you explain the regression?

hi @AkihiroSuda here I created issue with logs #11512

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ilya-zuyev, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants