Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Restore "containerd: upgrade io.containerd.runtime.v1.linux to io.containerd.runc.v2 (suppot cgroup v2)" #11556

Closed
wants to merge 1 commit into from

Conversation

ilya-zuyev
Copy link
Contributor

Reverts #11509

…to `io.containerd.runc.v2` (suppot cgroup v2)""
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 1, 2021
@ilya-zuyev
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 1, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ilya-zuyev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11556) |
+----------------+----------+---------------------+
| minikube start | 47.7s    | 47.2s               |
| enable ingress | 39.8s    | 35.0s               |
+----------------+----------+---------------------+

Times for minikube (PR 11556) ingress: 34.8s 35.2s 35.4s 34.2s 35.2s
Times for minikube ingress: 35.3s 35.4s 42.2s 43.7s 42.2s

Times for minikube start: 48.6s 45.6s 50.0s 46.8s 47.5s
Times for minikube (PR 11556) start: 47.8s 45.8s 48.5s 47.8s 46.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11556) |
+----------------+----------+---------------------+
| minikube start | 22.1s    | 21.6s               |
| enable ingress | 33.3s    | 35.4s               |
+----------------+----------+---------------------+

Times for minikube start: 23.0s 21.5s 22.2s 21.9s 21.9s
Times for minikube (PR 11556) start: 21.7s 22.5s 22.5s 21.2s 20.4s

Times for minikube ingress: 32.4s 31.5s 34.5s 33.9s 34.0s
Times for minikube (PR 11556) ingress: 34.5s 32.0s 36.5s 35.0s 38.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11556) |
+----------------+----------+---------------------+
| minikube start | 42.3s    | 44.7s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube (PR 11556) start: 43.7s 47.2s 43.1s 46.9s 42.7s
Times for minikube start: 30.8s 43.4s 47.1s 43.0s 47.4s

@ilya-zuyev
Copy link
Contributor Author

recreated as #11561

@ilya-zuyev ilya-zuyev closed this Jun 2, 2021
@medyagh medyagh deleted the revert-11509-revert-11325-cgroup2 branch January 20, 2022 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants