Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete: Clean up machine directory if DeleteHost fails to #5106

Merged
merged 1 commit into from
Aug 16, 2019

Conversation

tstromberg
Copy link
Contributor

@tstromberg tstromberg commented Aug 16, 2019

There are some situations where DeleteHost won't succeed. This outputs a warning, and tries to cleanup the directory anyways.

Old behavior with truncated config.json:

💣  Failed to delete cluster: Error getting migrated host: unexpected end of JSON input

😿  Sorry that minikube crashed. If this was unexpected, we would love to hear from you:
👉  https://github.com/kubernetes/minikube/issues/new/choose

New behavior with truncated config.json:

❌  Failed to delete cluster: load: filestore "minikube": Error getting migrated host: unexpected end of JSON input
📌  You may need to manually remove the "minikube" VM from your hypervisor
🔥  Removing /Users/tstromberg/.minikube/machines/minikube ...
💔  The "minikube" cluster has been deleted.

Closes #4286 and #5046

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 16, 2019
@tstromberg tstromberg changed the title delete: Clean up machines directory even if DeleteHost fails delete: Clean up machine directory even if DeleteHost fails Aug 16, 2019
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 16, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2019
@tstromberg tstromberg changed the title delete: Clean up machine directory even if DeleteHost fails delete: Clean up machine directory if DeleteHost fails to Aug 16, 2019
@medyagh
Copy link
Member

medyagh commented Aug 16, 2019

thanks for taking care of this.

I believe this was part of the delete all PR which has been wip for a while...#4780

@tstromberg tstromberg merged commit 96fcb91 into kubernetes:master Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

delete: remove VBox.log: The process cannot access the file because it is being used by another process.
4 participants