Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: minikube should not change the profile to a not existing profile #6772

Closed
wants to merge 1 commit into from

Conversation

RA489
Copy link

@RA489 RA489 commented Feb 24, 2020

minikube should not change the profile to a not existing profile.
fixes #6767

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 24, 2020
@RA489 RA489 requested a review from medyagh February 24, 2020 12:06
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 24, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RA489

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2020
@codecov-io
Copy link

Codecov Report

Merging #6772 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6772      +/-   ##
==========================================
- Coverage   38.62%   38.61%   -0.01%     
==========================================
  Files         142      142              
  Lines        8662     8664       +2     
==========================================
  Hits         3346     3346              
- Misses       4897     4899       +2     
  Partials      419      419
Impacted Files Coverage Δ
cmd/minikube/cmd/config/profile.go 0% <0%> (ø) ⬆️

@medyagh
Copy link
Member

medyagh commented Feb 24, 2020

@RA489 there is another PR by a new contributor that was created at the same time, if you dont mind we close this PR and help him with the first contribution ? #6774

@medyagh medyagh changed the title minikube should not change the profile to a not existing profile wip: minikube should not change the profile to a not existing profile Feb 24, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 24, 2020
@RA489
Copy link
Author

RA489 commented Feb 25, 2020

@medyagh sure.

@RA489
Copy link
Author

RA489 commented Feb 25, 2020

/close

@k8s-ci-robot
Copy link
Contributor

@RA489: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

minikube should not change the profile to a not existing profile
4 participants